To avoid memory corruption through string manipulation.

intorr · intorr · commit 0394afca5b0d · 2017-12-08T14:54:09.000+05:00
diff --git a/Externals/openal/OpenAL-Windows/Router/alc.cpp b/Externals/openal/OpenAL-Windows/Router/alc.cpp
@@ -570,7 +570,7 @@ ALvoid CleanDeviceSpecifierList()
 	// create new list
 	while (strlen(list) > 0) 
 	{
-		strcpy_s		(newListPtr, MAX_PATH, list);
+		strcpy_s		(newListPtr, MAX_PATH - (newListPtr - newList), list);
 		advancePtr		= TRUE;
 		if (strstr(newListPtr, T2A("DirectSound3D")) != NULL) 
 		{
diff --git a/src/xrEngine/line_edit_control.cpp b/src/xrEngine/line_edit_control.cpp
@@ -765,7 +765,7 @@ void remove_spaces(pstr str)
         while (b < str_size && str[b] != ' ')
             ++b;
 
-        strncpy_s(new_str + i, str_size + 1, str + a, b - a);
+        strncpy_s(new_str + i, str_size - i + 1, str + a, b - a);
         i += (b - a);
 
         if (i < str_size)

Original file line number	Diff line number	Diff line change
`@@ -570,7 +570,7 @@ ALvoid CleanDeviceSpecifierList()`
`570`	`570`	`// create new list`
`571`	`571`	`while (strlen(list) > 0)`
`572`	`572`	`{`
`573`		`- strcpy_s (newListPtr, MAX_PATH, list);`
	`573`	`+ strcpy_s (newListPtr, MAX_PATH - (newListPtr - newList), list);`
`574`	`574`	`advancePtr = TRUE;`
`575`	`575`	`if (strstr(newListPtr, T2A("DirectSound3D")) != NULL)`
`576`	`576`	`{`