fix bug no.4 - body position jitter (thx Valerok)

Author: yohjimane

src/xrGame/Actor.cpp

@@ -1516,7 +1516,16 @@ void CActor::shedule_Update(u32 DT)
 void CActor::renderable_Render(u32 context_id, IRenderable* root)
 {
     VERIFY(_valid(XFORM()));
-    inherited::renderable_Render(context_id, root);
+
+    if (m_firstPersonBody && psActorFlags.test(AF_FIRST_PERSON_BODY) && cam_active == eacFirstEye)
+    {
+        MakeMeCrow();
+        GEnv.Render->add_Visual(context_id, root, Visual(), firstPersonBodyXform);
+        Visual()->getVisData().hom_frame = Device.dwFrame;
+    }
+    else
+        inherited::renderable_Render(context_id, root);
+
     CInventoryOwner::renderable_Render(context_id, root);
 }
 
@@ -1546,12 +1555,11 @@ void CActor::RenderFirstPersonBody(u32 context_id, IRenderable* root)
 
     // adjust body position
     Fvector camdir = { cam_Active()->Direction().x, 0.f, cam_Active()->Direction().z }; // ignore Y (vertical) value
-    Fmatrix trans = XFORM();
-    trans.c.add(camdir.normalize().mul(g_first_person_body_offset)); // push model back so it doesn't look weird (default value: -0.75f)
-    XFORM().translate_over(trans.c); // move our original body to where our first person body is, so shadow renders in correct place
+    firstPersonBodyXform = XFORM();
+    firstPersonBodyXform.translate_add(camdir.normalize().mul(g_first_person_body_offset));
 
     // Add body to render
-    GEnv.Render->add_Visual(context_id, root, m_firstPersonBody, trans);
+    GEnv.Render->add_Visual(context_id, root, m_firstPersonBody, firstPersonBodyXform);
     m_firstPersonBody->getVisData().hom_frame = Device.dwFrame;
 
     // Copy transforms from actual body visual, excluding bones we don't want to animate
@@ -1561,7 +1569,6 @@ void CActor::RenderFirstPersonBody(u32 context_id, IRenderable* root)
         if (m_firstPersonBodyBonesToIgnoreAnims[i])
             continue;
 
-        kinematics->LL_GetTransform(i).set(realBodyK->LL_GetTransform(i));
         kinematics->LL_GetTransform_R(i).set(realBodyK->LL_GetTransform_R(i));
     }
 
@@ -1570,23 +1577,27 @@ void CActor::RenderFirstPersonBody(u32 context_id, IRenderable* root)
         kinematics->LL_SetBoneVisible(boneId, !vis, true);
 
     // Update head position
-    headPosition.set(trans);
-    headPosition.mulB_43(realBodyK->LL_GetTransform(realBodyK->LL_BoneID("bip01_head")));
+    headPosition.set(firstPersonBodyXform);
+    headPosition.mulB_43(realBodyK->LL_GetTransform_R(realBodyK->LL_BoneID("bip01_head")));
 
 #ifdef DEBUG
     Fvector ypr;
-    trans.getHPB(ypr);
+    firstPersonBodyXform.getHPB(ypr);
     string1024 text;
     CGameFont* F = UI().Font().pFontArial14;
     F->SetAligment(CGameFont::alLeft);
     F->OutSetI(-.9, 0);
     F->SetColor(color_rgba(255, 0, 0, 255));
-    xr_sprintf(text, "first person body position [%3.3f %3.3f %3.3f]", trans.c.x, trans.c.y, trans.c.z);
+    xr_sprintf(text, "first person body position [%3.3f %3.3f %3.3f]", firstPersonBodyXform.c.x, firstPersonBodyXform.c.y, firstPersonBodyXform.c.z);
+    F->OutNext(text);
+    xr_sprintf(text, "first person body direction [%3.3f %3.3f %3.3f]", firstPersonBodyXform.k.x, firstPersonBodyXform.k.y, firstPersonBodyXform.k.z);
     F->OutNext(text);
     xr_sprintf(text, "head position [%3.3f %3.3f %3.3f]", headPosition.c.x, headPosition.c.y, headPosition.c.z);
     F->OutNext(text);
     xr_sprintf(text, "camera position [%3.3f %3.3f %3.3f]", cam_Active()->Position().x, cam_Active()->Position().y, cam_Active()->Position().z);
     F->OutNext(text);
+    xr_sprintf(text, "camera direction [%3.3f %3.3f %3.3f]", cam_Active()->Direction().x, cam_Active()->Direction().y, cam_Active()->Direction().z);
+    F->OutNext(text);
 #endif // DEBUG
 }
 

src/xrGame/Actor.h

@@ -107,6 +107,7 @@ class CActor : public CEntityAlive,
     IRenderVisual* m_firstPersonBody{};
     xr_unordered_map<u16, bool> m_firstPersonBodyBonesToHide;
     xr_unordered_map<u16, bool> m_firstPersonBodyBonesToIgnoreAnims;
+    Fmatrix firstPersonBodyXform{};
     Fmatrix headPosition{};
 
     void feel_sound_new(IGameObject* who, int type, const CSound_UserDataPtr& user_data,