Fix bug related to removing inactual statics in CUIGameCustom::OnFrame.

Author: Pavel Kovalenko

src/xrGame/UIGameCustom.cpp

@@ -20,11 +20,6 @@
 
 EGameIDs ParseStringToGameType(const char* str);
 
-bool predicate_sort_stat(const SDrawStaticStruct* s1, const SDrawStaticStruct* s2)
-{
-    return s1->IsActual() > s2->IsActual();
-}
-
 struct predicate_find_stat
 {
     const char* id;
@@ -58,12 +53,13 @@ CUIGameCustom::~CUIGameCustom()
 void CUIGameCustom::OnFrame()
 {
     CDialogHolder::OnFrame();
-    auto it = CustomStatics.begin();
-    auto it_e = CustomStatics.end();
-    for (; it != it_e; ++it)
-        (*it)->Update();
-    // BUG: sort is never performed here, so not all inactual items will be deleted
-    std::sort(it, it_e, predicate_sort_stat);
+    for (auto item : CustomStatics)
+        item->Update();
+    auto comparer = [](const SDrawStaticStruct* s1, const SDrawStaticStruct* s2)
+    {
+        return s1->IsActual() > s2->IsActual();
+    };
+    std::sort(CustomStatics.begin(), CustomStatics.end(), comparer);
     while (!CustomStatics.empty() && !CustomStatics.back()->IsActual())
     {
         delete_data(CustomStatics.back());