Initialized unitialized variables in the constructor

Author: Xottab-DUTY

src/xrCDB/ISpatial.cpp

@@ -153,12 +153,13 @@ void ISpatial_NODE::_remove(ISpatial* S)
 
 ISpatial_DB::ISpatial_DB(const char* name) :
 #ifdef CONFIG_PROFILE_LOCKS
-    pcs(new Lock(MUTEX_PROFILE_ID(ISpatial_DB)))
+    pcs(new Lock(MUTEX_PROFILE_ID(ISpatial_DB))),
 #else
-    pcs(new Lock)
+    pcs(new Lock),
 #endif // CONFIG_PROFILE_LOCKS
+    rt_insert_object(nullptr), m_root(nullptr),
+    m_bounds(0), q_result(nullptr)
 {
-    m_root = NULL;
     xr_strcpy(Name, name);
 }
 

src/xrEngine/EffectorPP.h

@@ -13,7 +13,7 @@ class ENGINE_API CEffectorPP : public SBaseEffector
 
 public:
     CEffectorPP(EEffectorPPType type, f32 lifeTime, bool free_on_remove = true);
-    CEffectorPP() : bFreeOnRemove(true), fLifeTime(0.0f), bOverlap(true){};
+    CEffectorPP() : bFreeOnRemove(true), fLifeTime(0.0f), bOverlap(true) {};
     virtual ~CEffectorPP();
     BENCH_SEC_SCRAMBLEVTBL1
     virtual BOOL Process(SPPInfo& PPInfo);

src/xrEngine/Stats.cpp

@@ -163,6 +163,7 @@ void CStats::Show()
     {
         font.SetColor(color_rgba(255, 16, 16, 191));
         font.OutSet(400, 0);
+
         for (u32 it = (u32)_max(int(0), (int)errors.size() - g_ErrorLineCount); it < errors.size(); it++)
             font.OutNext("%s", errors[it].c_str());
     }

src/xrGame/ActorEffector.cpp

@@ -266,12 +266,12 @@ CCameraEffectorControlled::~CCameraEffectorControlled() { m_controller->SetCam(N
 BOOL CCameraEffectorControlled::Valid() { return m_controller->Valid(); }
 #define SND_MIN_VOLUME_FACTOR (0.1f)
 
-SndShockEffector::SndShockEffector()
+SndShockEffector::SndShockEffector() : m_end_time(0), m_life_time(0)
 {
     m_snd_length = 0.0f;
     m_cur_length = 0.0f;
     m_stored_volume = -1.0f;
-    m_actor = NULL;
+    m_actor = nullptr;
 }
 
 SndShockEffector::~SndShockEffector()

src/xrGame/BastArtifact.cpp

@@ -9,15 +9,15 @@
 #include "xrPhysics/extendedgeom.h"
 #include "ParticlesObject.h"
 
-CBastArtefact::CBastArtefact(void)
+CBastArtefact::CBastArtefact(void) : m_pHitedEntity(nullptr)
 {
     m_fImpulseThreshold = 10.f;
 
     m_fRadius = 10.f;
     m_fStrikeImpulse = 15.f;
 
     m_bStrike = false;
-    m_AttakingEntity = NULL;
+    m_AttakingEntity = nullptr;
 
     m_fEnergy = 0.f;
     m_fEnergyMax = m_fStrikeImpulse * 100.f;

src/xrGame/BoneProtections.h

@@ -14,12 +14,13 @@ struct SBoneProtections
     float m_fHitFracActor;
     typedef xr_map<s16, BoneProtection> storage_type;
     typedef storage_type::iterator storage_it;
-    SBoneProtections()
+    SBoneProtections() : m_fHitFracNpc(0)
     {
         m_default.koeff = 1.0f;
         m_default.armor = 0;
         m_fHitFracActor = 0.1f;
     }
+
     BoneProtection m_default;
     storage_type m_bones_koeff;
     void reload(const shared_str& outfit_section, IKinematics* kinematics);

src/xrGame/Car.h

@@ -183,7 +183,7 @@ class CCar : public CEntity,
         void SetSteerLimits(float hi, float lo);
 
         virtual void ApplyDamage(u16 level);
-        SWheel(CCar* acar)
+        SWheel(CCar* acar) : radius(0)
         {
             bone_id = BI_NONE;
             car = acar;
@@ -321,6 +321,9 @@ class CCar : public CEntity,
         };
         eState state;
         SDoor(CCar* acar)
+            : update(false), pos_open(0),
+              opened_angle(0), closed_angle(0),
+              open_time(0)
         {
             bone_id = BI_NONE;
             pcar = acar;

src/xrGame/CarSound.cpp

@@ -10,7 +10,7 @@
 
 // extern CPHWorld*	ph_world;
 #include "xrPhysics/IPHWorld.h"
-CCar::SCarSound::SCarSound(CCar* car)
+CCar::SCarSound::SCarSound(CCar* car) : eCarSound(), engine_start_delay(0), time_state_start(0)
 {
     volume = 1.f;
     pcar = car;

src/xrGame/ClimableObject.cpp

@@ -48,7 +48,7 @@ IC void OrientToNorm(const Fvector& normal, Fmatrix& form, Fobb& box)
     }
 }
 
-CClimableObject::CClimableObject() : m_pStaticShell(NULL), m_material(u16(-1)) {}
+CClimableObject::CClimableObject() : m_pStaticShell(nullptr), m_radius(0), m_material(u16(-1)) {}
 CClimableObject::~CClimableObject() {}
 void CClimableObject::Load(LPCSTR section) { inherited::Load(section); }
 BOOL CClimableObject::net_Spawn(CSE_Abstract* DC)

src/xrGame/CustomDetector.cpp

@@ -11,10 +11,10 @@
 #include "player_hud.h"
 #include "weapon.h"
 
-ITEM_INFO::ITEM_INFO()
+ITEM_INFO::ITEM_INFO() : snd_time(0), cur_period(0)
 {
-    pParticle = NULL;
-    curr_ref = NULL;
+    pParticle = nullptr;
+    curr_ref = nullptr;
 }
 
 ITEM_INFO::~ITEM_INFO()
@@ -25,7 +25,7 @@ ITEM_INFO::~ITEM_INFO()
 
 bool CCustomDetector::CheckCompatibilityInt(CHudItem* itm, u16* slot_to_activate)
 {
-    if (itm == NULL)
+    if (itm == nullptr)
         return true;
 
     CInventoryItem& iitm = itm->item();