Fix Wunused-variable warnings

Author: AMS21

src/Layers/xrRender/r__dsgraph_build.cpp

@@ -90,7 +90,7 @@ void R_dsgraph_structure::insert_dynamic(IRenderable* root, dxRender_Visual* pVi
 
 // Shadows registering
 #if RENDER == R_R1
-    RI.L_Shadows->add_element(_MatrixItem{ SSA, root, pVisual, xform });
+    RI.L_Shadows->add_element(_MatrixItem{SSA, root, pVisual, xform});
 #endif
     if (root && root->renderable_Invisible())
         return;

src/utils/xrQSlim/MxQSlim.cpp

@@ -298,7 +298,6 @@ void MxEdgeQSlim::apply_mesh_penalties(MxQSlimEdge* info)
     if (nfailed)
         bias += nfailed * meshing_penalty;
 
-    static u32 a = 0;
     //	if (a)
     {
         double Nmin1 = check_local_inversion(info->v1, info->v2, info->vnew);
@@ -481,8 +480,7 @@ void MxEdgeQSlim::update_pre_contract(const MxPairContraction& conx)
         if (u == v1 || varray_find(star, u))
         {
             // This is a useless link --- kill it
-            bool found = varray_find(edge_links(u), e, &j);
-            VERIFY(found);
+            VERIFY(varray_find(edge_links(u), e, &j));
             edge_links(u).remove(j);
             heap.remove(e);
             if (u != v1)

src/utils/xrQSlim/MxStdModel.cpp

@@ -48,8 +48,7 @@ MxVertexID MxStdModel::alloc_vertex(float x, float y, float z)
     vertex_mark_valid(id);
 
     face_links.add(xr_new<MxFaceList>());
-    unsigned int l = face_links.last_id();
-    VERIFY(l == id);
+    VERIFY(face_links.last_id() == id);
     VERIFY(neighbors(id).length() == 0);
 
     return id;
@@ -560,8 +559,7 @@ void MxStdModel::apply_expansion(const MxPairExpansion& conx)
         MxFaceID fid = conx.delta_faces(i);
         face(fid).remap_vertex(v1, v2);
         neighbors(v2).add(fid);
-        bool found = varray_find(neighbors(v1), fid, &j);
-        VERIFY(found);
+        VERIFY(varray_find(neighbors(v1), fid, &j));
         neighbors(v1).remove(j);
     }
 

src/xrAICore/Navigation/PatrolPath/patrol_path_storage.cpp

@@ -31,8 +31,7 @@ void CPatrolPathStorage::load_raw(
 
         shared_str patrol_name;
         sub_chunk->r_stringZ(patrol_name);
-        const_iterator I = m_registry.find(patrol_name);
-        VERIFY3(I == m_registry.end(), "Duplicated patrol path found", *patrol_name);
+        VERIFY3(m_registry.find(patrol_name) == m_registry.end(), "Duplicated patrol path found", *patrol_name);
         m_registry.emplace(
             patrol_name, &(xr_new<CPatrolPath>(patrol_name))->load_raw(level_graph, cross, game_graph, *sub_chunk)
 		);

src/xrAICore/Navigation/graph_vertex_inline.h

@@ -65,8 +65,7 @@ IC typename _graph_type::CEdge* CSGraphVertex::edge(const _vertex_id_type& verte
 TEMPLATE_SPECIALIZATION
 IC void CSGraphVertex::add_edge(CGraphVertex* vertex, const typename _graph_type::CEdge::edge_weight_type& edge_weight)
 {
-    typename EDGES::iterator I = std::find(m_edges.begin(), m_edges.end(), vertex->vertex_id());
-    VERIFY(m_edges.end() == I);
+    VERIFY(m_edges.end() == std::find(m_edges.begin(), m_edges.end(), vertex->vertex_id()));
     vertex->on_edge_addition(this);
     m_edges.push_back(typename _graph_type::CEdge(edge_weight, vertex));
     ++*m_edge_count;
@@ -86,8 +85,7 @@ IC void CSGraphVertex::remove_edge(const _vertex_id_type& vertex_id)
 TEMPLATE_SPECIALIZATION
 IC void CSGraphVertex::on_edge_addition(CGraphVertex* vertex)
 {
-    typename VERTICES::const_iterator I = std::find(m_vertices.begin(), m_vertices.end(), vertex);
-    VERIFY(I == m_vertices.end());
+    VERIFY(std::find(m_vertices.begin(), m_vertices.end(), vertex) == m_vertices.end());
     m_vertices.push_back(vertex);
 }
 

src/xrEngine/Rain.cpp

@@ -14,21 +14,21 @@
 #endif
 
 // Warning: duplicated in dxRainRender
-static const int max_desired_items = 2500;
-static const float source_radius = 12.5f;
+//static const int max_desired_items = 2500;
+//static const float source_radius = 12.5f;
 static const float source_offset = 40.f;
 static const float max_distance = source_offset * 1.25f;
-static const float sink_offset = -(max_distance - source_offset);
-static const float drop_length = 5.f;
-static const float drop_width = 0.30f;
+//static const float sink_offset = -(max_distance - source_offset);
+//static const float drop_length = 5.f;
+//static const float drop_width = 0.30f;
 static const float drop_angle = 3.0f;
 static const float drop_max_angle = deg2rad(10.f);
 static const float drop_max_wind_vel = 20.0f;
 static const float drop_speed_min = 40.f;
 static const float drop_speed_max = 80.f;
 
 const int max_particles = 1000;
-const int particles_cache = 400;
+//const int particles_cache = 400;
 const float particles_time = .3f;
 
 //////////////////////////////////////////////////////////////////////

src/xrEngine/XR_IOConsole.cpp

@@ -14,9 +14,8 @@
 #include "GameFont.h"
 
 #include "Include/xrRender/UIRender.h"
+#include "xrUICore/ui_defs.h"
 
-static float const UI_BASE_WIDTH = 1024.0f;
-static float const UI_BASE_HEIGHT = 768.0f;
 static float const LDIST = 0.05f;
 static u32 const cmd_history_max = 64;
 

src/xrEngine/xrSheduler.cpp

@@ -319,7 +319,10 @@ void CSheduler::ProcessStep()
 {
     // Normal priority
     const u32 dwTime = Device.dwTimeGlobal;
+
+#ifdef DEBUG
     CTimer eTimer;
+#endif
 
     for (int i = 0; !Items.empty() && Top().dwTimeForExecute < dwTime; ++i)
     {

src/xrGame/Actor.cpp

@@ -75,9 +75,9 @@
 #include "ui/UIDragDropReferenceList.h"
 #include "xrCore/xr_token.h"
 
-const u32 patch_frames = 50;
-const float respawn_delay = 1.f;
-const float respawn_auto = 7.f;
+//const u32 patch_frames = 50;
+//const float respawn_delay = 1.f;
+//const float respawn_auto = 7.f;
 
 constexpr float default_feedback_duration = 0.2f;
 

src/xrGame/ActorAnimation.cpp

@@ -316,10 +316,11 @@ CMotion* FindMotionKeys(MotionID motion_ID, IRenderVisual* V)
 
 #ifdef DEBUG
 BOOL g_ShowAnimationInfo = FALSE;
-#endif // DEBUG
 constexpr pcstr mov_state[] = {
     "idle", "walk", "run", "sprint",
 };
+#endif // DEBUG
+
 void CActor::g_SetAnimation(u32 mstate_rl)
 {
     if (!g_Alive())