SoundRender_Source.cpp: Add BUG.

nitrocaster · nitrocaster · commit bdd8343f1fee · 2016-01-14T18:52:41.000+03:00
diff --git a/src/xrSound/SoundRender_Source.cpp b/src/xrSound/SoundRender_Source.cpp
@@ -57,7 +57,7 @@ void CSoundRender_Source::i_decompress_fr(OggVorbis_File* ovf, char* _dest, u32
 	while (TotalRet < (long)left) 
 	{
 		ret = ov_read(ovf, /*PCM*/ _dest+ TotalRet, left - TotalRet, 0, 2, 1, &current_section);
-
+        // BUG: ov_read can return negative value indicating an error, making this loop infinite
 		// if end of file or read limit exceeded
 		if (ret == 0) break;
 		else if (ret < 0) 		// Error in bitstream

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ void CSoundRender_Source::i_decompress_fr(OggVorbis_File* ovf, char* _dest, u32`
`57`	`57`	`while (TotalRet < (long)left)`
`58`	`58`	`{`
`59`	`59`	`ret = ov_read(ovf, /PCM/ _dest+ TotalRet, left - TotalRet, 0, 2, 1, &current_section);`
`60`		`-`
	`60`	`+ // BUG: ov_read can return negative value indicating an error, making this loop infinite`
`61`	`61`	`// if end of file or read limit exceeded`
`62`	`62`	`if (ret == 0) break;`
`63`	`63`	`else if (ret < 0) // Error in bitstream`