From b80861de9c58bef1c6596cdeac9f284dcb5481e0 Mon Sep 17 00:00:00 2001
From: tuxuser <462620+tuxuser@users.noreply.github.com>
Date: Fri, 22 Dec 2023 00:04:48 +0100
Subject: [PATCH] clippy, small documentation fixup

---
 src/authenticator.rs | 5 +----
 src/models.rs        | 4 ++--
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/authenticator.rs b/src/authenticator.rs
index cfbd625..c5dabc8 100644
--- a/src/authenticator.rs
+++ b/src/authenticator.rs
@@ -410,10 +410,7 @@ impl XalAuthenticator {
     pub fn oauth_client(&self) -> Result<BasicClient, Error> {
         let client = OAuthClient::new(
             ClientId::new(self.app_params.client_id.to_string()),
-            self.app_params
-                .client_secret
-                .clone()
-                .map(|x| ClientSecret::new(x)),
+            self.app_params.client_secret.clone().map(ClientSecret::new),
             AuthUrl::new(Constants::OAUTH20_AUTHORIZE_URL.to_string())?,
             Some(TokenUrl::new(Constants::OAUTH20_TOKEN_URL.to_string())?),
         )
diff --git a/src/models.rs b/src/models.rs
index ab611b7..abaeffc 100644
--- a/src/models.rs
+++ b/src/models.rs
@@ -506,9 +506,9 @@ impl ToString for DeviceType {
 /// Mandatory for XAL authentication flow
 #[derive(Debug, Serialize, Deserialize, PartialEq, Eq, Clone)]
 pub struct XalAppParameters {
-    /// App Id (For authorization/permission scope)
+    /// OAuth2 Client Id
     pub client_id: String,
-    /// App Title-Id (For TitleToken)
+    /// App Title-Id (Required for SISU auth flow, for TitleToken)
     pub title_id: Option<String>,
     /// Scopes
     pub auth_scopes: Vec<Scope>,