Skip to content

Commit 9d777df

Browse files
Transpile 7e2f66a
1 parent 6753832 commit 9d777df

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/workflows/checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787
- uses: actions/checkout@v3
8888
- name: Set up environment
8989
uses: ./.github/actions/setup
90-
- uses: crytic/slither-action@v0.1.1
90+
- uses: crytic/slither-action@v0.2.0
9191

9292
codespell:
9393
if: github.repository != 'OpenZeppelin/openzeppelin-contracts-upgradeable'

contracts/governance/TimelockControllerUpgradeable.sol

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,9 @@ contract TimelockControllerUpgradeable is Initializable, AccessControlUpgradeabl
326326
*
327327
* - the caller must have the 'executor' role.
328328
*/
329+
// This function can reenter, but it doesn't pose a risk because _afterCall checks that the proposal is pending,
330+
// thus any modifications to the operation during reentrancy should be caught.
331+
// slither-disable-next-line reentrancy-eth
329332
function executeBatch(
330333
address[] calldata targets,
331334
uint256[] calldata values,

slither.config.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"detectors_to_run": "reentrancy-eth,reentrancy-no-eth,reentrancy-unlimited-gas",
3-
"filter_paths": "contracts/mocks"
3+
"filter_paths": "contracts/mocks",
4+
"compile_force_framework": "hardhat"
45
}

0 commit comments

Comments
 (0)