Skip to content

Commit 71102f4

Browse files
authored
Update index.js
1 parent ddcd29a commit 71102f4

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Diff for: scripts/solhint-custom/index.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,15 @@ module.exports = [
7575
static ruleId = 'no-external-virtual';
7676

7777
FunctionDefinition(node) {
78-
// Skip constructor functions, interface definitions, and receive/fallback functions
78+
// Skip constructor functions, interface definitions, receive/fallback functions,
79+
// and governance/multicall functions which legitimately use external virtual
7980
if (
8081
node.isConstructor ||
8182
node.parent.kind === 'interface' ||
8283
node.name === '' || // receive/fallback functions have empty names
8384
node.isReceiveEther ||
84-
node.isFallback
85+
node.isFallback ||
86+
/^(update|multicall)/.test(node.name) // Allow external virtual for update* and multicall functions
8587
) {
8688
return;
8789
}

0 commit comments

Comments
 (0)