Skip to content

Consider an @oz-renamespaced-from tag to redeclare ERC-7201 namespace tags. #1132

Open
@ernestognw

Description

@ernestognw
function _getInitializableStorage() internal virtual pure returns (InitializableStorage storage $) {

Would be a smaller change, that we could easily generalize to all the upgradeable contracts. The downside is that overriding it would likely require the user writting assembly.

I'm just realizing that this would not really be "good" to generalize, because it gives the developper direct/easy access to the storage. Its basically like making the storage variables internal instead of private. I don't think its a good idea.

Right now I'd favor the current code.

@arr00 @ernestognw wdyt ? should we finally merge this ?

Originally posted by @Amxx in OpenZeppelin/openzeppelin-contracts#5337 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions