🎁 [Feature Request]: Regression tests for bug patches

[4meta5]

templates

• Generic Runtime Template
• Evm Template

What is the feature you would like to see?

There have been a lot of bug patches recently. While updating the pallet abstraction macros in OpenZeppelin/openzeppelin-pallet-abstractions#1 to include the patches, it was noticed that templates/main lacks regression tests that would fail when the patches are reverted and the bugs are reintroduced.

We need to

1. Require all bug patching PRs to include regression tests that fail before the PR's changes.
2. Add regression tests for all previous bug patches which forgot to include them

The priority for this issue is increased now that we are extracting pallet configs into the macros.

(1) can be addressed by

• updating the PR template to include a check for regression tests if it is a bug fix
• requesting regression tests during bug fix reviews (manually)

(2) requires

• make a list of all previously merged bug fixes which lacked regression tests
• add regression tests for all of the bug fixes on that list

Contribution Guidelines

• I agree to follow this project's Contribution Guidelines