-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement /press page #171
Comments
This is a request for a new or redesigned page.
|
My Pr should not close this issue, its only a copy of the live site. No new content has been added. |
Thanks to @dirtyredz a ton of the work is already done. The issue still needs the newly requested content + some style tweaks. |
Do we have a new design template? So i can look into tweaking styles and more specifically where were looking at adding the above referenced media articles. |
There's no mock to speak of here. Some of the style issues I noticed, if you'd like to tackle them:
|
The horizontal centering doesn't look terribly off but notice it the most on lower device sizes. Ill see what can be done for those. The other issue look fairly straight forward. |
To be clear, I wasn't being critical of your work. It's actually a very strange issue, since you've simply brought over the old code and there shouldn't be styling regressions. Thanks again for doing so much! |
I understand, i figured it was a matter of browser or device that was causing the distinct difference. |
Chrome@latest for what it's worth |
This latest PR should close out this issue. A few merge conflicts need to get fixed but doesn't look like anything major. |
Assigning myself as a placeholder for @dirtyredz |
Feature
Why is this feature being added?
https://operationcode.org/press exists and it needs to exist in the new code base as well.
What should your feature do?
pages/press.js
The text was updated successfully, but these errors were encountered: