[drape] calculate spline length during the iteration

during the `CalculatePointColor` the `GetLength` is called on the every iteration
and it should returns the value as fast as possible. The previous solution with
`accumulate` slows down the track rendering performance a lot.

Signed-off-by: Kiryl Kaveryn <[email protected]>

Author: kirylkaveryn

drape_frontend/gps_track_renderer.cpp

@@ -204,6 +204,7 @@ void GpsTrackRenderer::RenderTrack(ref_ptr<dp::GraphicsContext> context, ref_ptr
     double const currentScaleGtoP = 1.0 / screen.GetScale();
     double const radiusMercator = m_radius / currentScaleGtoP;
     double const diameterMercator = 2.0 * radiusMercator;
+    double const step = diameterMercator + kDistanceScalar * diameterMercator;
 
     // Update points' positions and colors.
     ASSERT(!m_renderData.empty(), ());
@@ -231,15 +232,16 @@ void GpsTrackRenderer::RenderTrack(ref_ptr<dp::GraphicsContext> context, ref_ptr
     {
       m2::Spline::iterator it;
       it.Attach(m_pointsSpline);
+      auto const fullLength = it.GetFullLength();
+      double lengthFromStart = 0.0;
       while (!it.BeginAgain())
       {
         m2::PointD const pt = it.m_pos;
         m2::RectD pointRect(pt.x - radiusMercator, pt.y - radiusMercator,
                             pt.x + radiusMercator, pt.y + radiusMercator);
         if (screen.ClipRect().IsIntersect(pointRect))
         {
-          dp::Color const color = CalculatePointColor(it.GetIndex(), pt,
-                                                      it.GetLength(), it.GetFullLength());
+          dp::Color const color = CalculatePointColor(it.GetIndex(), pt, lengthFromStart, fullLength);
           m2::PointD const convertedPt = MapShape::ConvertToLocal(pt, m_pivot, kShapeCoordScalar);
           m_handlesCache[cacheIndex].first->SetPoint(m_handlesCache[cacheIndex].second,
                                                      convertedPt, m_radius, color);
@@ -254,7 +256,8 @@ void GpsTrackRenderer::RenderTrack(ref_ptr<dp::GraphicsContext> context, ref_ptr
             return;
           }
         }
-        it.Advance(diameterMercator + kDistanceScalar * diameterMercator);
+        lengthFromStart += step;
+        it.Advance(step);
       }
 
 #ifdef GPS_TRACK_SHOW_RAW_POINTS

geometry/spline.cpp

@@ -174,11 +174,6 @@ void Spline::iterator::Advance(double step)
     AdvanceForward(step);
 }
 
-double Spline::iterator::GetLength() const
-{
-  return std::accumulate(m_spl->m_length.begin(), m_spl->m_length.begin() + m_index, m_dist);
-}
-
 double Spline::iterator::GetFullLength() const
 {
   return m_spl->GetLength();

geometry/spline.hpp

@@ -22,7 +22,6 @@ class Spline
     void Attach(Spline const & spl);
     void Advance(double step);
     bool BeginAgain() const;
-    double GetLength() const;
     double GetFullLength() const;
 
     size_t GetIndex() const;