Fix Buffer Overflow (#640)

gabrielOFlores · web-flow · commit 0f737cdde067 · 2026-02-01T11:29:24.000-05:00
Update GetInt functions to use array for results with a fixed size of 4
diff --git a/Sources/OvRendering/src/OvRendering/HAL/OpenGL/GLBackend.cpp b/Sources/OvRendering/src/OvRendering/HAL/OpenGL/GLBackend.cpp
@@ -89,16 +89,16 @@ namespace
 
 	int GetInt(uint32_t p_parameter)
 	{
-		GLint result;
-		glGetIntegerv(p_parameter, &result);
-		return static_cast<int>(result);
+		GLint result[4];
+		glGetIntegerv(p_parameter, result);
+		return static_cast<int>(result[0);
 	}
 
 	int GetInt(uint32_t p_parameter, uint32_t p_index)
 	{
-		GLint result;
-		glGetIntegeri_v(p_parameter, p_index, &result);
-		return static_cast<int>(result);
+		GLint result[4];
+		glGetIntegeri_v(p_parameter, p_index, result);
+		return static_cast<int>(result[0]);
 	}
 
 	float GetFloat(uint32_t p_parameter)

Original file line number	Diff line number	Diff line change
`@@ -89,16 +89,16 @@ namespace`
`89`	`89`
`90`	`90`	`int GetInt(uint32_t p_parameter)`
`91`	`91`	`{`
`92`		`- GLint result;`
`93`		`- glGetIntegerv(p_parameter, &result);`
`94`		`- return static_cast<int>(result);`
	`92`	`+ GLint result[4];`
	`93`	`+ glGetIntegerv(p_parameter, result);`
	`94`	`+ return static_cast<int>(result[0);`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`int GetInt(uint32_t p_parameter, uint32_t p_index)`
`98`	`98`	`{`
`99`		`- GLint result;`
`100`		`- glGetIntegeri_v(p_parameter, p_index, &result);`
`101`		`- return static_cast<int>(result);`
	`99`	`+ GLint result[4];`
	`100`	`+ glGetIntegeri_v(p_parameter, p_index, result);`
	`101`	`+ return static_cast<int>(result[0]);`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`float GetFloat(uint32_t p_parameter)`