Merge pull request #29 from PDOK/jd/aliasses

Added IngressRouteURLs

Author: jelledijkstra97

api/v1/zz_generated.deepcopy.go

@@ -0,0 +1,11 @@
+package model
+
+// IngressRouteURLs
+// +kubebuilder:validation:MinItems:=1
+// Without maxItems x-kubernetes-validation complains about an exceeded computation budget as the list can grow infinitely in theory
+// +kubebuilder:validation:MaxItems:=30
+type IngressRouteURLs []IngressRouteURL
+
+type IngressRouteURL struct {
+	URL URL `json:"url"`
+}

model/ingress_route_urls.go

@@ -0,0 +1,47 @@
+package validation
+
+import (
+	"fmt"
+	"github.com/pdok/smooth-operator/model"
+	"k8s.io/apimachinery/pkg/util/validation/field"
+)
+
+func ValidateIngressRouteURLsContainsBaseURL(urls model.IngressRouteURLs, baseURL model.URL, path *field.Path) *field.Error {
+	if path == nil {
+		path = field.NewPath("spec").Child("ingressRouteUrls")
+	}
+
+	if len(urls) == 0 {
+		return nil
+	}
+
+	for _, url := range urls {
+		if url.URL.String() == baseURL.String() {
+			return nil
+		}
+	}
+
+	return field.Invalid(path, urls, fmt.Sprintf("must contain baseURL: %s", baseURL))
+}
+
+func ValidateIngressRouteURLsNotRemoved(oldURLs, newURLs model.IngressRouteURLs, allErrs *field.ErrorList, path *field.Path) {
+	if path == nil {
+		path = field.NewPath("spec").Child("ingressRouteUrls")
+	}
+
+	for _, url := range oldURLs {
+		s := url.URL.String()
+		found := false
+
+		for _, newURL := range newURLs {
+			if newURL.URL.String() == s {
+				found = true
+				break
+			}
+		}
+
+		if !found {
+			*allErrs = append(*allErrs, field.Invalid(path, newURLs, fmt.Sprintf("urls cannot be removed: %s", url)))
+		}
+	}
+}

model/zz_generated.deepcopy.go

@@ -0,0 +1,117 @@
+package validation
+
+import (
+	"github.com/pdok/smooth-operator/model"
+	"github.com/stretchr/testify/assert"
+	"k8s.io/apimachinery/pkg/util/validation/field"
+	"testing"
+)
+
+func TestURLsContainsBaseURL(t *testing.T) {
+	URL1, _ := model.ParseURL("http://test.com/test")
+	URL2, _ := model.ParseURL("http://test.com/other")
+	URL3, _ := model.ParseURL("http://test.com/other/path")
+	type args struct {
+		urls    model.IngressRouteURLs
+		baseURL model.URL
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantErr bool
+	}{
+		{
+			name: "Contains BaseURL",
+			args: args{
+				urls:    model.IngressRouteURLs{{URL: model.URL{URL: URL1}}, {URL: model.URL{URL: URL2}}},
+				baseURL: model.URL{URL: URL1},
+			},
+			wantErr: false,
+		},
+		{
+			name: "Does not contain BaseURL",
+			args: args{
+				urls:    model.IngressRouteURLs{{URL: model.URL{URL: URL1}}, {URL: model.URL{URL: URL2}}},
+				baseURL: model.URL{URL: URL3},
+			},
+			wantErr: true,
+		},
+		{
+			name: "No ingressRouteURLs",
+			args: args{
+				urls:    model.IngressRouteURLs{},
+				baseURL: model.URL{URL: URL3},
+			},
+			wantErr: false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := ValidateIngressRouteURLsContainsBaseURL(tt.args.urls, tt.args.baseURL, nil)
+			if tt.wantErr {
+				assert.NotEmpty(t, err)
+			} else {
+				assert.Empty(t, err)
+			}
+		})
+	}
+}
+
+func TestURLsNotRemoved(t *testing.T) {
+	URL1, _ := model.ParseURL("http://test.com/test")
+	URL2, _ := model.ParseURL("http://test.com/other")
+	URL3, _ := model.ParseURL("http://test.com/other/path")
+	type args struct {
+		old model.IngressRouteURLs
+		new model.IngressRouteURLs
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantErr bool
+	}{
+		{
+			name: "Same set",
+			args: args{
+				old: model.IngressRouteURLs{{URL: model.URL{URL: URL1}}, {URL: model.URL{URL: URL2}}},
+				new: model.IngressRouteURLs{{URL: model.URL{URL: URL1}}, {URL: model.URL{URL: URL2}}},
+			},
+			wantErr: false,
+		},
+		{
+			name: "Same set (both empty)",
+			args: args{
+				old: model.IngressRouteURLs{},
+				new: model.IngressRouteURLs{},
+			},
+			wantErr: false,
+		},
+		{
+			name: "One URL removed",
+			args: args{
+				old: model.IngressRouteURLs{{URL: model.URL{URL: URL1}}, {URL: model.URL{URL: URL2}}},
+				new: model.IngressRouteURLs{{URL: model.URL{URL: URL1}}},
+			},
+			wantErr: true,
+		},
+		{
+			name: "One URL added",
+			args: args{
+				old: model.IngressRouteURLs{{URL: model.URL{URL: URL1}}, {URL: model.URL{URL: URL2}}},
+				new: model.IngressRouteURLs{{URL: model.URL{URL: URL1}}, {URL: model.URL{URL: URL2}}, {URL: model.URL{URL: URL3}}},
+			},
+			wantErr: false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			allErrs := field.ErrorList{}
+			ValidateIngressRouteURLsNotRemoved(tt.args.old, tt.args.new, &allErrs, nil)
+			if tt.wantErr {
+				assert.NotEmpty(t, allErrs)
+			} else {
+				assert.Empty(t, allErrs)
+			}
+		})
+	}
+}