Merge #2936: [Cleanup] Unify header guards

76b04cb lint: Add include guard linter (Fuzzbawls)
f3a5eda Cleanup: Unify header guards (Fuzzbawls)

Pull request description:

  For a while now, we've been using a mish-mash of various header guard styles, with no real consistency project wide. This PR remedies that by setting a strict header guard notation style.

  All first-party headers now follow the below guard style:
  ```cpp
  #ifndef PIVX_<PATH_TO>_<FILENAME>_H
  #define PIVX_<PATH_TO>_<FILENAME>_H
  ...
  #endif // PIVX_<PATH_TO>_<FILENAME>_H
  ```
  Git subtrees and integrated 3rd party libraries are excluded.

  A linter is included so as to prevent future inclusion of include guards that do not adhere to the above standard style.

  With this in place, there is more opportunity to "declutter" our file structure quite a bit, **especially** with regards to the GUI files.

ACKs for top commit: 76b04cb
  panleone:
    tACK 76b04cb
  Liquid369:
    tACK 76b04cb
  Duddino:
    ACK 76b04cb

Tree-SHA512: 8a42e2d110137775148404d37012d622a75ee7b6a90ee3691984e6d3f7f4179bc783a9dc38c66e7fdc317c71e987c56e57d6652aaed4ad6cffe8905e66881ccf

Author: Fuzzbawls

src/activemasternode.h

@@ -3,8 +3,8 @@
 // Distributed under the MIT/X11 software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
-#ifndef ACTIVEMASTERNODE_H
-#define ACTIVEMASTERNODE_H
+#ifndef PIVX_ACTIVEMASTERNODE_H
+#define PIVX_ACTIVEMASTERNODE_H
 
 #include "key.h"
 #include "evo/deterministicmns.h"
@@ -117,4 +117,4 @@ bool GetActiveMasternodeKeys(CTxIn& vin, Optional<CKey>& key, CBLSSecretKey& bls
 // Get active masternode BLS operator keys for DMN
 bool GetActiveDMNKeys(CBLSSecretKey& key, CTxIn& vin);
 
-#endif
+#endif // PIVX_ACTIVEMASTERNODE_H

src/addrdb.h

@@ -4,8 +4,8 @@
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
-#ifndef BITCOIN_ADDRDB_H
-#define BITCOIN_ADDRDB_H
+#ifndef PIVX_ADDRDB_H
+#define PIVX_ADDRDB_H
 
 #include "fs.h"
 #include "serialize.h"
@@ -94,4 +94,4 @@ class CBanDB
     bool Read(banmap_t& banSet);
 };
 
-#endif //BITCOIN_ADDRDB_H
+#endif // PIVX_ADDRDB_H

src/addressbook.h

@@ -50,4 +50,4 @@ namespace AddressBook {
 
 }
 
-#endif //PIVX_ADDRESSBOOK_H
+#endif // PIVX_ADDRESSBOOK_H

src/addrman.h

@@ -4,8 +4,8 @@
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
-#ifndef BITCOIN_ADDRMAN_H
-#define BITCOIN_ADDRMAN_H
+#ifndef PIVX_ADDRMAN_H
+#define PIVX_ADDRMAN_H
 
 #if defined(HAVE_CONFIG_H)
 #include "config/pivx-config.h"
@@ -742,4 +742,4 @@ friend class CAddrManTest;
 
 };
 
-#endif // BITCOIN_ADDRMAN_H
+#endif // PIVX_ADDRMAN_H

src/amount.h

@@ -15,4 +15,4 @@ typedef int64_t CAmount;
 static const CAmount COIN = 100000000;
 static const CAmount CENT = 1000000;
 
-#endif //  PIVX_AMOUNT_H
+#endif // PIVX_AMOUNT_H

src/arith_uint256.h

@@ -3,8 +3,8 @@
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
-#ifndef BITCOIN_ARITH_UINT256_H
-#define BITCOIN_ARITH_UINT256_H
+#ifndef PIVX_ARITH_UINT256_H
+#define PIVX_ARITH_UINT256_H
 
 #include <assert.h>
 #include <cstring>
@@ -385,4 +385,4 @@ arith_uint512 UintToArith512(const uint512 &);
 const arith_uint256 ARITH_UINT256_ZERO = arith_uint256();
 const arith_uint256 ARITH_UINT256_ONE = arith_uint256(1);
 
-#endif // BITCOIN_UINT256_H
+#endif // PIVX_ARITH_UINT256_H

src/attributes.h

@@ -3,8 +3,8 @@
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
-#ifndef BITCOIN_ATTRIBUTES_H
-#define BITCOIN_ATTRIBUTES_H
+#ifndef PIVX_ATTRIBUTES_H
+#define PIVX_ATTRIBUTES_H
 
 #if defined(__has_cpp_attribute)
 #  if __has_cpp_attribute(nodiscard)
@@ -29,4 +29,4 @@
 #  define LIFETIMEBOUND
 #endif
 
-#endif // BITCOIN_ATTRIBUTES_H
+#endif // PIVX_ATTRIBUTES_H

src/base58.h

@@ -12,8 +12,8 @@
  * - E-mail usually won't line-break if there's no punctuation to break at.
  * - Double-clicking selects the whole number as one word if it's all alphanumeric.
  */
-#ifndef BITCOIN_BASE58_H
-#define BITCOIN_BASE58_H
+#ifndef PIVX_BASE58_H
+#define PIVX_BASE58_H
 
 #include "attributes.h"
 #include "chainparams.h"
@@ -65,4 +65,4 @@ NODISCARD bool DecodeBase58Check(const char* psz, std::vector<unsigned char>& vc
  */
 NODISCARD bool DecodeBase58Check(const std::string& str, std::vector<unsigned char>& vchRet, int max_ret_len);
 
-#endif // BITCOIN_BASE58_H
+#endif // PIVX_BASE58_H

src/bech32.h

@@ -8,8 +8,9 @@
 // 6 characters of which are a checksum.
 //
 // For more information, see BIP 173.
-#ifndef BITCOIN_BECH32_H
-#define BITCOIN_BECH32_H
+
+#ifndef PIVX_BECH32_H
+#define PIVX_BECH32_H
 
 #include <stdint.h>
 #include <string>
@@ -26,4 +27,4 @@ std::pair<std::string, std::vector<uint8_t>> Decode(const std::string& str);
 
 } // namespace bech32
 
-#endif // BITCOIN_BECH32_H
+#endif // PIVX_BECH32_H

src/bench/bench.h

@@ -2,8 +2,8 @@
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
-#ifndef BITCOIN_BENCH_BENCH_H
-#define BITCOIN_BENCH_BENCH_H
+#ifndef PIVX_BENCH_BENCH_H
+#define PIVX_BENCH_BENCH_H
 
 #include <chrono>
 #include <functional>
@@ -138,4 +138,4 @@ class PlotlyPrinter : public Printer
 #define BENCHMARK(n, num_iters_for_one_second) \
     benchmark::BenchRunner BOOST_PP_CAT(bench_, BOOST_PP_CAT(__LINE__, n))(BOOST_PP_STRINGIZE(n), n, (num_iters_for_one_second));
 
-#endif // BITCOIN_BENCH_BENCH_H
+#endif // PIVX_BENCH_BENCH_H