Skip to content

Conversation

@jdebacker
Copy link
Member

With the updates to ogusa_default_parameters.json in PR #140, the tax_func_type was not updated to "HSV". This PR makes that change.

The ogusa_default_parameters_2sector.json is also simplified, keeping just the parameters that need to be changed on top of the ogusa_default_parameters.json changes used in the one-sector model.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.69%. Comparing base (e76f917) to head (71c9153).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   45.69%   45.69%           
=======================================
  Files          18       18           
  Lines        1416     1416           
=======================================
  Hits          647      647           
  Misses        769      769           
Flag Coverage Δ
unittests 45.69% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ogusa/__init__.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdebacker
Copy link
Member Author

@rickecon this PR is ready for your review.

@jdebacker jdebacker requested a review from rickecon September 27, 2025 19:52
@rickecon
Copy link
Member

rickecon commented Oct 2, 2025

@jdebacker. The file ogusa_default_parameters_2sector.json has been reduced to a very small number of specifications. However, shouldn't this be almost as big as ogusa_default_parameters.json? I thought the usage was to call one or the other, not one after the other. If we are following the former workflow, then ogusa_default_parameters_2sector.json should be bigger. LMK

@jdebacker
Copy link
Member Author

@rickecon asks:

The file ogusa_default_parameters_2sector.json has been reduced to a very small number of specifications. However, shouldn't this be almost as big as ogusa_default_parameters.json? I thought the usage was to call one or the other, not one after the other. If we are following the former workflow, then ogusa_default_parameters_2sector.json should be bigger. LMK

I think it makes sense to keep the JSON files small so they are more readable. So I recommend the workflow of adding one on top of another. It adds only one line of code to layer updates like this and it saves about 10MB of disk space to use the smaller 2 sector JSON file. Both would already be included with the package so if one has OG-USA installed, they can load both if they wish.

@rickecon
Copy link
Member

rickecon commented Oct 2, 2025

@jdebacker. I noticed that we don't have an example of this multi-country preferred parameter update workflow, neither in the OG-USA repo nor the OG-Core repo.

@rickecon
Copy link
Member

rickecon commented Oct 3, 2025

@jdebacker. I just submitted a PR to your update_baseline branch for this PR. I simply increased the debt_ratio_ss to 2.6. and updated the cit_rate changes over time, which matches the data. I can merge this PR as soon as you review and merge my PR to your branch.

@rickecon
Copy link
Member

rickecon commented Oct 3, 2025

Looks good to me. All questions answered. Merging now. @jdebacker

@rickecon rickecon merged commit c2a637a into PSLmodels:master Oct 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants