Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot proxy the given URL #1195

Open
renakdup opened this issue Aug 2, 2024 · 4 comments
Open

Cannot proxy the given URL #1195

renakdup opened this issue Aug 2, 2024 · 4 comments

Comments

@renakdup
Copy link

renakdup commented Aug 2, 2024

Bug Report

Due to the latest update on the GH, images are proxied via GH, due to that we got errors for pictures of badges:

Cannot proxy the given URL
image

With the example you can familiarize yourself here https://github.com/renakdup/simple-dic/tree/main

Q A
BC Break yes/no
Library Version x.y.z
PHP version x.y.z

Summary

Current behavior

Pictures should load via GH proxy.

How to reproduce

Expected behavior

@blancks
Copy link

blancks commented Aug 24, 2024

I'm here to report the same thing and share my findings about that.

The https redirect seems to be the culprit here, because github seems to expect the url to return the actual image but got instead the 301 redirect:

curl -I http://poser.pugx.org/blancks/fast-jsonpatch-php/require/php
HTTP/1.1 301 Moved Permanently
Server: awselb/2.0
Date: Sat, 24 Aug 2024 17:07:03 GMT
Content-Type: text/html
Content-Length: 134
Connection: keep-alive
Location: https://poser.pugx.org:443/blancks/fast-jsonpatch-php/require/php

Once figured that out i just replaced the badge url with its https version https://poser.pugx.org/blancks/fast-jsonpatch-php/require/php and it worked just fine

@JellyBellyDev
Copy link
Member

Thanks for the report @renakdup and for the solution @blancks.
I think that we should fix the example code copy in homepage and/or try to improve the software for following the 301.

WDYT @garak?

@garak
Copy link
Member

garak commented Sep 6, 2024

I think we should go with https, I can't see any reason to still use http

@cgsmith
Copy link

cgsmith commented Sep 25, 2024

I am having the same issue. It would be nice to switch to https

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants