You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, a rule group move is performed by moving all the rules around a reference pivot point. For example, if we have N rules in a group and want to move that set of rules before/after a reference rule, we perform N number of API calls. This is not optimal and can be optimised to perform the least number of moves required to achieve the desired outcome.
The text was updated successfully, but these errors were encountered:
The MoveGroup() currently implemented by the generator is better than the old pango logic, but this can be further enhanced.
The current logic determines a pivot rule (last rule in the group if the group is to be located somewhere before or directly before a given rule, otherwise the pivot rule is the first rule in the group), and then after determining the pivot rule, move one index at a time and ensure that that specific index is as desired. This is an enhancement from blindly moving stuff from before, but may not be the most efficient way to accomplish this goal.
IMPORTANT NOTE: Whatever logic comes out of this enhancement, I don't think it's valid to intentionally move a rule that is not in the group. Only rules listed as belonging to the group should be moved.
Example: let's say we want the rules to be ordered like this, with a pivot of top:
A > B > C > D > E
But they are actually like this currently:
A > E > B > C > D
The current logic would move rules B, C, and D. But the better way would be to just move E after D and you're done.
Currently, a rule group move is performed by moving all the rules around a reference pivot point. For example, if we have N rules in a group and want to move that set of rules before/after a reference rule, we perform N number of API calls. This is not optimal and can be optimised to perform the least number of moves required to achieve the desired outcome.
The text was updated successfully, but these errors were encountered: