Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename vmseries -> swfw #1

Merged
merged 8 commits into from
Jan 25, 2024
Merged

chore: rename vmseries -> swfw #1

merged 8 commits into from
Jan 25, 2024

Conversation

migara
Copy link
Member

@migara migara commented Jan 8, 2024

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@migara migara changed the title rename vmseries -> swfw chore: rename vmseries -> swfw Jan 8, 2024
@migara
Copy link
Member Author

migara commented Jan 8, 2024

/help

ChatOPS built in help:

Currently supported commands include:

  • /sca - run all SCA tests via pre-commit
  • /validate - run terraform validate
  • /plan - plan the infrastructure (only examples)
  • /apply - deploy the infrastructure and destroy afterwards (only examples)
  • /idempotence - test idempotence: deploy, plan and destroy afterwards (only examples).

The 1st command does not take arguments, the remaining take two:

  • paths - a space delimitied list of module paths
  • tf_version - (optional, defaults to the latest available) a space delimited list of Terraform versions to test the infrastrucure against.

Examples:

# run idempotence tests on listed modules with Terraform versions: 1.2 (latest patch available), 1.4 (latest patch available), 1.5.4.
/idempotence paths="examples/common_vmseries examples/panorama_standalone" tf_version="1.2 1.4 1.5.4"
# run validation tests with the latest available Terraform version on listed modules.
/validate paths="modules/vmseries modules/vnet examples/dedicated_vmseries"

@migara
Copy link
Member Author

migara commented Jan 8, 2024

/plan paths="modules/vmseries"

Testing job ID: 7449689186
Job result: FAILURE
Job result: FAILURE
Job result: SUCCESS

@migara migara requested review from a team and removed request for a team January 11, 2024 18:24
Copy link
Contributor

@alperenkose alperenkose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will need to re-upload images only.

@@ -12,7 +12,7 @@ Virtual Machine Scale Sets (VMSS) are used for autoscaling to run the Next Gener

## Reference Architecture Design

![simple](https://github.com/PaloAltoNetworks/terraform-azurerm-vmseries-modules/assets/6574404/a7c2452d-f926-49da-bf21-9d840282a0a2)
![simple](https://github.com/PaloAltoNetworks/terraform-azurerm-swfw-modules/assets/6574404/a7c2452d-f926-49da-bf21-9d840282a0a2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these images will need to be re-uploaded in order to create github.com assets links. needed for all images.

@migara migara merged commit 0e5dca1 into main Jan 25, 2024
5 checks passed
@migara migara deleted the swfw-rename branch January 25, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants