-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(example/gwlb_with_vmseries): Refactor Gateway Load Balancer example #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should keep Common and GWLB examples separate as GWLB is not in the reference architecture design guide yet. We also have links from pan.dev to the repository examples for these designs so merging them with different example.tfvars can cause confusion.
General question; if we keep the GWLB example separate shall we still keep the un-compatible modules in the example code like NATGW or AppGW ? I believe these resources are not possible to integrate with GWLB, and it might bring confusion/doubts to the users trying out the example.
So summing up today's discussion during the planning meeting, we decided not to share common codebase with GWLB example, it will remain separate. We will also transform the test_infrastructure example into a module and then integrate it with all examples but for now (in scope of this PR), I think the test infra can remain a part of the GWLB example. |
thanks @alperenkose for review, I updated the code, there is no Application Gateway and NAT Gateway in the @acelebanski I removed changes from common design and I left refactored example for GWLB together test VMs. PR is ready to being reviewed. |
Description
PR is a part of #9 and it delivers Gateway Load Balancer in refactored example
gwlb_with_vmseries
.Motivation and Context
In #3 all modules and examples are being refactored according to issue description. PR 372 in archived repository delivered changes in
gwlb
module, but it didn't contain refactored example with Gateway Load Balancer.How Has This Been Tested?
Code was tested by deploying example in the lab.
Types of changes
Checklist