Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enable Google provider version 5 (remove max version constraint) #7

Merged
merged 6 commits into from
Apr 3, 2024
Merged

chore: Enable Google provider version 5 (remove max version constraint) #7

merged 6 commits into from
Apr 3, 2024

Conversation

MyMirelHub
Copy link
Contributor

@MyMirelHub MyMirelHub commented Jan 17, 2024 •
edited
Loading

Description

This update includes bumping the Terraform version to 5.12. The primary goal of this change is to ensure compatibility with the latest google api features and improvements, as well as to maintain up-to-date practices within our infrastructure management.

Motivation and Context

Major version API upgrades are essential for leveraging the latest functionalities and enhancements offered by the Google provider. This change is driven by the need to stay aligned with the evolving landscape of infrastructure as code (IaC) and to utilize the improved performance and features of the latest google version.

#6

How Has This Been Tested?

Followed the contributor's guideline and ran pre-commit run -a to ensure the unit tests were passing

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@MyMirelHub MyMirelHub changed the title bump google provider version to 5.12 build: Bump Google provider version to 5.12 Jan 17, 2024
@MyMirelHub MyMirelHub marked this pull request as ready for review January 17, 2024 17:59
@MyMirelHub MyMirelHub requested a review from a team as a code owner January 17, 2024 17:59
@michalbil
Copy link
Contributor

michalbil commented Feb 8, 2024 •
edited by github-actions bot
Loading

/validate paths="modules/autoscale modules/iam_service_account modules/lb_http_ext_global modules/panorama modules/vpc modules/vpn modules/bootstrap modules/lb_external modules/lb_internal modules/vmseries modules/vpc-peering"

Testing job ID: 7829019815
Job result: FAILURE
Testing job ID: 7829019815
Job result: FAILURE
Testing job ID: 7829019815
Job result: FAILURE

@michalbil
Copy link
Contributor

michalbil commented Feb 8, 2024 •
edited by github-actions bot
Loading

/validate paths="modules/autoscale modules/iam_service_account modules/lb_http_ext_global modules/panorama modules/vpc modules/vpn modules/bootstrap modules/lb_external modules/lb_internal modules/vmseries modules/vpc-peering"

Testing job ID: 7837537002
Job result: FAILURE
Testing job ID: 7837537002
Job result: FAILURE

@michalbil
Copy link
Contributor

@MyMirelHub there is one issue with google_secret_manager_secret argument that needs to be fixed to work with the new provider version, details can be found in validation job logs.

@michalbil michalbil mentioned this pull request Mar 7, 2024
Closed
@michalbil
Copy link
Contributor

@MyMirelHub the issue has been fixed in upstream, can you please sync your fork and rebase the PR?

@pavelrn
Copy link
Contributor

pavelrn commented Apr 2, 2024 •
edited by github-actions bot
Loading

/validate paths="modules/autoscale modules/iam_service_account modules/lb_http_ext_global modules/panorama modules/vpc modules/vpn modules/bootstrap modules/lb_external modules/lb_internal modules/vmseries modules/vpc-peering"

Testing job ID: 8528816710
Job result: FAILURE

@pavelrn
Copy link
Contributor

pavelrn commented Apr 2, 2024 •
edited by github-actions bot
Loading

/validate paths="modules/autoscale modules/iam_service_account modules/lb_http_ext_global modules/panorama modules/vpc modules/vpn modules/bootstrap modules/lb_external modules/lb_internal modules/vmseries modules/vpc-peering"

Testing job ID: 8529106334
Job result: SUCCESS

michalbil
michalbil requested changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@michalbil michalbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavelrn can you please update PR title to reflect the changes?

modules/autoscale/versions.tf Outdated Show resolved Hide resolved
@pavelrn pavelrn changed the title build: Bump Google provider version to 5.12 build: Allow Google provider version 5 Apr 3, 2024
@pavelrn pavelrn changed the title build: Allow Google provider version 5 build: Enable Google provider version 5 (remove max version contraint) Apr 3, 2024
@pavelrn pavelrn changed the title build: Enable Google provider version 5 (remove max version contraint) build: Enable Google provider version 5 (remove max version constraint) Apr 3, 2024
@pavelrn pavelrn requested a review from michalbil April 3, 2024 08:50
@pavelrn pavelrn changed the title build: Enable Google provider version 5 (remove max version constraint) chore: Enable Google provider version 5 (remove max version constraint) Apr 3, 2024
@pavelrn pavelrn merged commit fb1381d into PaloAltoNetworks:main Apr 3, 2024
10 of 41 checks passed
@michalbil michalbil linked an issue Apr 3, 2024 that may be closed by this pull request
Update Google Provider Version to v5 #6
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalbil michalbil michalbil approved these changes

@pavelrn pavelrn pavelrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Google Provider Version to v5
3 participants
@MyMirelHub @michalbil @pavelrn