Adapt Papirus to KDE Plasma 6 #3663
Comments
|
The removable devices tray icon also shows a colored version, not a monochrome version - not sure this is intended |
|
Relevant post from Nate: |
|
I was about to make this same issue! Papirus is my favorite icon pack. Looking forward to using it with Plasma 6! |
|
Panel related adaptions was once mentioned by #3595. |
|
Plasma 5 |
|
I support we are waiting for Plasma 6! Papirus is the best set! |
|
do we make the symbolic klipper icon to be a generic metal clip icon ( |
|
Okay guys, I don't think it is possible to have a solution right now. KDE colour scheme icons currently only have sizes up to 24px in Papirus, but the ones that were previously used inside the Plasma themes need to have 32px and 22px sizes. There's no place for symbolic 32px icons at the moment. And even after figuring out where to put them, the necessary scripts for preparing and converting the icons need to be modified. I managed to assemble a quick-and-dirty solution, but I think it is better not to merge it. We need restructuring. I guess I can finally understand what @SmartFinn meant by his harsh reaction to this change in Plasma 6. |
|
I could even start adding some necessary 32px symbolic icons myself, perhaps in the apps folder or in a new folder somewhere, but I'm not experienced in the project structure and script writing, so I'll be waiting for Serhii to say his word. |
It looks like KDE has done something similar to Breeze Icons 6. In one of Nate Graham's blog posts he said that Plasma 6 will adapt to the way GNOME uses the -symbolic suffix, which may mean that icon makers can put the symbolic icons in all sizes, alongside the coloured ones. |
@monstorix we could, but as I've said we need some non-trivial restructuring. The situation is dire because symbolic icons which are used in GNOME don't adapt their colour, but the icons with the KDE colourscheme support do. And now they are mixed up. I haven't given it much thought, but it seems like another challenge. |
|
Sorry, I don't have enough time to install KDE on my laptop to see the changes. I suppose that I wrote a script that converts 16px icons into 22px, and 24px, sometime ago. So it shouldn't be a problem. However, we should find the right icon theme structure at first. Another way is creating a fork for Plasma 6. |
|
Another thing that may affect the works: |
|
Honestly, I can't remember any place in GTK where 24px icons are used. GNOME uses 16px in menus, buttons, panel, sidebars, and toolbars. 22px is using for appindicators and tray. |
|
Well, the GTK compatibility saying is also from Nate. It might not pointed to any specific DEs. |
|
Couldn't we just use the icons from the Materia theme? They seem to fit quite well! |
|
Couldn't we just use the icons from the Materia theme? They seem to fit quite well!
The problem is, every icon in materia plasma 5 theme (in all of them, really) has both 32px and 22px shapes inside the file: small icons are used for the panel and the bigger ones appear when you open the systray widget. Papirus has no place for these 32px symbolic icons yet, that's why it's not so simple.
|
We'd have to do a lot of it manually, I guess, but for icons that we don't have in Papirus, we could just extract the 22px versions and put them in a separate SVG |
|
We'd have to do a lot of it manually, I guess, but for icons that we don't have in Papirus, we could just extract the 22px versions and put them in a separate SVG
That's what i did locally before realising that we need restructuring. I've used plasma theme with materia icons myself.
|
|
Honestly, I can't remember any place in GTK where 24px icons are used. GNOME uses 16px in menus, buttons, panel, sidebars, and toolbars. 22px is using for appindicators and tray.
@SmartFinn if understand correctly, the KDE developers are talking about compatibility in a broader context — 22px icons aren't present in GTK at all, are they? That's why they want to get rid of them. As for the 24px icons, I actually wasn't able to find if they are used in any of my installed applications, but they are still in the specification and they are used if the app developer chooses to use them, right?
|
The 24px actions icons are often using in GTK-based DE, such as Xfce, in toolbars. However, we're talking about symbolic icons that are mostly 16px. 24px symbolic icons are using in elementaryOS, and in Xfce 4 in few places. |
16px symbolic icons are perfectly scaled to 32px. Rules in index.theme file allow it. |
|
16px symbolic icons are perfectly scaled to 32px. Rules in index.theme file allow it.
@SmartFinn
Neat, but there's an issue: all of them need to be adapted, because the icons in the symbolic directory lack KDE colour scheme support. For example, there's a pending merge request with symlinks for power profiles in symbolic directiry, but I've tried it and the icons have a different colour on a panel compared to the icons from the panel directory
|
|
@morganist could you try to add these icons without |
|
@Erwin-Iosef category icons small, because used 22px icons, but not blurred... |
|
@varlesh Doesn't look well what about 24px you can use those right? |
|
no, used 22px on source code |
|
you can disable also maybe need clear cache and restart plasmashell
|
|
Now master branch have new structure folder, big thx @SmartFinn for you hard work! |
|
Thanks @SmartFinn and great job! |
|
Just tried it looks great! Great job guys! The Power Management button is still colored though as shown here any plans to do anything about it @varlesh ?
Apart from the stuff I already mentioned, everything looks great! Lemme know if there are any plans forward. |
|
temporary solution on hide tray menu: restart plasmashell
|
|
@Erwin-Iosef What OS you use? Or maybe you know when wine category location on Kickoff? |
|
This is not much of a problem but if you're interested: It removes the "messy" ./ characters from the target paths of the symlinks since they're all on the same folder. |
|
ePapirus will be removed |
|
@varlesh I use Arch Linux, I think wine category came up when I installed windows programs in wine. Not much of a problem really unless if you want to create a new symbolic wine icon. |
The messy links are present in other Papirus folders too: I didn't post the full output since it's extensive. |
|
@Erwin-Iosef Yes, i want create wine sybolic icon, because on kickoff used symbolic icons as default now. i'm use arch too, but not have this category |
|
You got to install a software that will install the app shortcuts to "Start Menu" which wine will designate to local/share/applications I bet and thus get translated onto kickoff. |
|
|
|
@Erwin-Iosef thx for report |
|
@Erwin-Iosef @varlesh there are no broken symlinks in this repo. Stop fighting for nothing. |
|
We're not fighting, I just reported a nice maintenance fix that's all. |
|
@Erwin-Iosef I wrote a test that check all symlinks in this repo for every commit, so I'm sure there is nothing to fix. Changing valid symlinks because a utility called them messy, well, it doesn't improve anything. Unless, someone uses this command in CI/CD. In this case, we'll save a lot of space, reducing the complaint in their logs. |
|
Wine create new category on ~/.local/share/desktop-directories/wine-wine.directory i'm added wine-symbolic icon, but KF5 not present this category, it's can be fixed manually, if need use symbolic icon |
|
@SmartFinn @varlesh Now with the major changes done to Papirus, do you have plans for a release? |
|
@Erwin-Iosef not now, we have this issue #3923 |
|
Dolphin's small icon is weirdly wrong despite it being correct in Icon Explorer
Edit: dolphin is requesting |
and others
A message from maintainers:
This issue collects all known issues and bugs regarding the transition from Plasma 5 to Plasma 6!
Before reporting a new problem or bug, please check if the problem is still present when using the latest Papirus git master (use install script in our root directory, see project README)
For useful background regarding new symbolic icons in plasma 6, see Plasma 6 applets use system icons so missing many icons for applet #3595
Please understand that Papirus icon theme had already included symbolic icons prior to the Plasma 6 release and those icons now show up in plasma as unthemeable (either dark grey or white, they don't follow the text colour of your colour scheme). You need to use Papirus-Dark for these icons to appear white.
Please report such icons, but acknowledge that this is something that can only be fixed with some restructuring within Papirus, possibly even splitting the theme in two (KDE and GTK editions).
FAQ
Q: I use Plasma and have Breeze-Dark theme applied. Symbolic Papirus icons are white, but sometimes an icon stands out because it is dark grey. How to make solve this issue?
A: Apply Papirus-Dark instead of just Papirus. While the majority of symbolic icons will adapt to your text colour, these GNOME symbolic icons will not, because they were not intended to do that by Advaita developers. Manually choosing the Papirus flavour will make them blend in with other icons.
Q: I applied the appropriate Papirus flavour but the problematic icons appear blurry when compared to others. How to solve this?
A: These icons have a fixed size of 16x16 pixels, because that's how the modern GTK apps use icons. Most of our icons have different sizes (16px, 22px, 24px, 32px, etc.) so that they render crisply in all situations. However, these GNOME symbolic icons only render correctly at the context of symbolic icons at 2x scale (16, 32, 64, 128, 256px). If they are on a panel where the icon size is 22px (Plasma panel by default), they will appear blurry. Adjust your icon size to be either 16px or 32px or use margin separator widgets on Plasma panels to separate different icon sizes.
Q: How to resolve this whole mess?
A: Advocate for a unified symbolic icon implementation between GNOME and KDE so that icon themes like Papirus are able to make one icon for every desktop environment and have it not look awful. If one spec-compliant icon theme is in practice incompatible with some desktop environment, what is the purpose of the specification?
Original message:
KDE Plasma 6 seems to have changed the names of some icons used in the system tray / system settings / etc. As a result, these icons will fall back to the default Breeze icon theme, even though Papirus has adequate icons (with different names) for them.
Here is a list of icons that I have noticed so far:
brightness-high-symbolic,redshift-status-off-symbolic,redshift-status-on-symbolic,redshift-status-day-symbolic: Used in the brightness controllerklipper-symbolic: Used in the clipboard managernotifications-disabled-symbolic,notification-active-symbolic,notification-inactive-symbolic: Used in the notification managerkdeconnect-tray-symbolic: Used by KDE Connect(everything above could also have their counterparts without "-symbolic")
network-flightmode-on: Used by the network managerinput-touchscreen: Used by system settingsNote that this is not an exhaustive list. Maybe we can refer to the new Breeze icon theme repository to find what's not included in Papirus.
The text was updated successfully, but these errors were encountered: