Skip to content

Commit 4e8a843

Browse files
bc-leelibyuv LUCI CQ
authored and
libyuv LUCI CQ
committed
Fix missing headers in GN/GYP build files
While porting libyuv's GN to other build systems, I discovered that several headers were absent in the GN and GYP build files. These headers are utilized in the source files but were not included in the GN and GYP build configurations. Without these headers, the Bazel build fails with the following error: ERROR: /path/to/bazel/external/libyuv/BUILD.bazel:4:11: Compiling source/compare.cc failed: (Exit 1): clang-17 failed: error executing CppCompile command (from target @@libyuv//:libyuv) /usr/bin/clang-17 -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++14' ... (remaining 32 arguments skipped) Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging external/libyuv/source/compare.cc:20:10: fatal error: 'libyuv/compare_row.h' file not found 20 | #include "libyuv/compare_row.h" | ^~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Bug: None Change-Id: I39c4c545e381d5f28c749f9ba8940e039aa55dfc Reviewed-on: https://chromium-review.googlesource.com/c/libyuv/libyuv/+/5380588 Reviewed-by: Mirko Bonadei <[email protected]> Commit-Queue: Mirko Bonadei <[email protected]>
1 parent ba796a3 commit 4e8a843

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

BUILD.gn

+3
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,14 @@ static_library("libyuv_internal") {
106106
"include/libyuv.h",
107107
"include/libyuv/basic_types.h",
108108
"include/libyuv/compare.h",
109+
"include/libyuv/compare_row.h",
109110
"include/libyuv/convert.h",
110111
"include/libyuv/convert_argb.h",
111112
"include/libyuv/convert_from.h",
112113
"include/libyuv/convert_from_argb.h",
113114
"include/libyuv/cpu_id.h",
115+
"include/libyuv/loongson_intrinsics.h",
116+
"include/libyuv/macros_msa.h",
114117
"include/libyuv/mjpeg_decoder.h",
115118
"include/libyuv/planar_functions.h",
116119
"include/libyuv/rotate.h",

libyuv.gypi

+2
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@
1313
'include/libyuv.h',
1414
'include/libyuv/basic_types.h',
1515
'include/libyuv/compare.h',
16+
'include/libyuv/compare_row.h',
1617
'include/libyuv/convert.h',
1718
'include/libyuv/convert_argb.h',
1819
'include/libyuv/convert_from.h',
1920
'include/libyuv/convert_from_argb.h',
2021
'include/libyuv/cpu_id.h',
22+
'include/libyuv/loongson_intrinsics.h',
2123
'include/libyuv/macros_msa.h',
2224
'include/libyuv/mjpeg_decoder.h',
2325
'include/libyuv/planar_functions.h',

0 commit comments

Comments
 (0)