Skip to content

Commit 0e9a85b

Browse files
committed
Don't fail by grepping
1 parent 0a271e6 commit 0e9a85b

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

.github/workflows/benchmarks.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,13 @@ jobs:
5656
echo "Contender: ${GITHUB_SHA} ($PR_HEAD_LABEL)"
5757
# Run benchmarks for current commit against base
5858
ASV_OPTIONS="--split --show-stderr --factor $ASV_FACTOR --verbose"
59-
# asv continuous $ASV_OPTIONS ${{ github.event.pull_request.base.sha }} ${GITHUB_SHA} \
60-
asv continuous $ASV_OPTIONS ${GITHUB_SHA} \
59+
asv continuous $ASV_OPTIONS ${{ github.event.pull_request.base.sha }} ${GITHUB_SHA} \
6160
| sed "/Traceback \|failed$\|PERFORMANCE DECREASED/ s/^/::error::/" \
6261
| tee benchmarks.log
63-
# Report and export results for subsequent steps
64-
if grep "Traceback \|failed\|PERFORMANCE DECREASED" benchmarks.log > /dev/null ; then
65-
exit 1
66-
fi
62+
# # Report and export results for subsequent steps
63+
# if grep "Traceback \|failed\|PERFORMANCE DECREASED" benchmarks.log > /dev/null ; then
64+
# exit 1
65+
# fi
6766
working-directory: ${{ env.ASV_DIR }}
6867

6968
- name: Add instructions to artifact

asv_bench/benchmarks/benchmarks_particle_execution.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ def setup(self):
7171

7272
def time_run_single_timestep(self):
7373
self.pset.execute(AdvectionRK4, runtime=timedelta(seconds=1 * 5), dt=timedelta(seconds=5))
74-
print("single step", self.pset[0].time)
7574

7675
def time_run_many_timesteps(self):
7776
self.pset.execute(AdvectionRK4, runtime=timedelta(seconds=100 * 5), dt=timedelta(seconds=5))
78-
print("multi step", self.pset[0].time)

0 commit comments

Comments
 (0)