RabbitMq transports creates unnecssary exchanges

[ekjuanrejon]

Describe the bug

Description

use conventions to determine which is an event

Expected behavior

Create exchanges only the subscribed events

Actual behavior

Exchanges is created for all types in the class library

Versions

10.1.3
Please list the version of the relevant packages or applications in which the bug exists.

Steps to reproduce

1. Use NSB 9 and Rabbitmq transport 10.1.3

Relevant log output

Additional Information

Workarounds

Possible solutions

Additional information

[bording]

Hi @ekjuanrejon, it sounds like the behavior you are describing is not a bug, but actual intended behavior to make publishing events work correctly.

You can see more information about the exchanges that are created for each event here.

If you are seeing something other than the type hierarchy of the events being created as exchanges, then you'll need to provide more specific details to let us know what you're seeing. Ideally, you'd provide screenshots showing all the exchanges that have been created that you think are incorrect along with the full type hierarchy information of the event you're publishing.

[ekjuanrejon]

Hi @bording

I cannot share screenshots. However I check the same version of the service running with NSB 8 and rabbitmq 8 and there is about 44 exchangees. With nsb 9 and rabbit then there is triple. Exchange for class that are not even an event just a value object class

[bording]

I cannot share screenshots. However I check the same version of the service running with NSB 8 and rabbitmq 8 and there is about 44 exchangees. With nsb 9 and rabbit then there is triple. Exchange for class that are not even an event just a value object class

I'm not aware of anything that changed between those versions, so I'm going to need you to provide more information or a simple repro project that shows the behavior that you're referring to.

[ekjuanrejon]

Hmm in previous versions i only had exchanges for the type which was in the event handler. Now I have exchanges for dto classes or value object

[bording]

I did a quick test using version 8.0.8 of the transport.

I have the following message classes:

class MyBaseEvent;
class MyEvent : MyBaseEvent;

This handler:

class MyEventHandler : IHandleMessages<MyEvent>

And this convention:

endpointConfiguration.Conventions().DefiningEventsAs(t => t == typeof(MyEvent));

Here are the results of the running the endpoint:

---

As you can see, the full message inheritance chain is created. This is how the conventional routing topology works, and it has always worked this way.

If it ever changed, it would be a wire compatibility breaking change that would prevent endpoints running on different versions of the transport from being able to communicate to each other.