Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AutoDeleteOnIdle setting #359

Closed
wants to merge 1 commit into from

Conversation

steve-haar
Copy link

exposes AutoDeleteOnIdle setting for queues and topics.

closes #358

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

/// <summary>
/// Overrides the default time to auto delete queues and topics when idle.
/// </summary>
[ObsoleteEx(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setting (if added) shouldn't be obsoleted.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed setting from AzureServiceBusSettings

get => autoDeleteOnIdle;
set
{
if (value < TimeSpan.FromMinutes(5))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a comment with a link to the docs about the minimal value of QueueDescription.AutoDeleteOnIdle.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment with link to microsoft docs

@stale
Copy link

stale bot commented Jul 28, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 28, 2021
@stale stale bot closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose AutoDeleteOnIdle setting
3 participants