Skip to content

Direct access to $_GET / $_POST not allowed #6

Open
@danmarsden

Description

@danmarsden

Direct access to $_GET and $_POST is typically not allowed -

this check could probably be replaced with a simple if (data_submitted()) { call:
https://github.com/PaystackHQ/plugin-moodle/blob/main/verify.php#L50

Ideally this should be rewritten to use Moodle's optional_param/required_param functions with appropriate PARAM cleaning on each known var - surely the API only returns some specific parameters in the response and you know what these are?
https://github.com/PaystackHQ/plugin-moodle/blob/main/verify.php#L60

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions