config.h: invalid preprocessing directive `# HAS_LC_MONETARY_2008 /**/`

[dilyanpalauzov]

I downloaded perl-5.38.2, unpacked it, ran ./Configure && make. The latter failed with

echo @`sh  cflags "optimize='-O2'" opmini.o`  -DPERL_IS_MINIPERL -DPERL_EXTERNAL_GLOB opmini.c
@cc -c -DPERL_CORE -D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2 -Wall -Wno-use-after-free -DPERL_IS_MINIPERL -DPERL_EXTERNAL_GLOB opmini.c
In file included from perl.h:44,
                 from op.c:163:
config.h:2892:3: error: invalid preprocessing directive #HAS_LC_MONETARY_2008
 2892 | # HAS_LC_MONETARY_2008          /**/
      |   ^~~~~~~~~~~~~~~~~~~~
make: *** [makefile:313: opmini.o] Error 1

Indeed, config.h contains # HAS_LC_MONETARY_2008 /**/ and this is invalid preprocessor input.

[jkeenan]

I downloaded perl-5.38.2, unpacked it, ran ./Configure && make. The latter failed with

echo @`sh  cflags "optimize='-O2'" opmini.o`  -DPERL_IS_MINIPERL -DPERL_EXTERNAL_GLOB opmini.c
@cc -c -DPERL_CORE -D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2 -Wall -Wno-use-after-free -DPERL_IS_MINIPERL -DPERL_EXTERNAL_GLOB opmini.c
In file included from perl.h:44,
                 from op.c:163:
config.h:2892:3: error: invalid preprocessing directive #HAS_LC_MONETARY_2008
 2892 | # HAS_LC_MONETARY_2008          /**/
      |   ^~~~~~~~~~~~~~~~~~~~
make: *** [makefile:313: opmini.o] Error 1

Indeed, config.h contains # HAS_LC_MONETARY_2008 /**/ and this is invalid preprocessor input.

Can you supply the output of:

$ uname -a
$ locale

Thanks.

[dilyanpalauzov]

# uname -a
Linux mail 5.10.198 #5 SMP Sun Nov 19 15:01:30 UTC 2023 x86_64 GNU/Linux
# locale
LANG=
LC_CTYPE=en_US.UTF-8
LC_NUMERIC="POSIX"
LC_TIME="POSIX"
LC_COLLATE="POSIX"
LC_MONETARY="POSIX"
LC_MESSAGES="POSIX"
LC_PAPER="POSIX"
LC_NAME="POSIX"
LC_ADDRESS="POSIX"
LC_TELEPHONE="POSIX"
LC_MEASUREMENT="POSIX"
LC_IDENTIFICATION="POSIX"
LC_ALL=

[jkeenan]

Also, what -- if anything do you have for:

d_lc_monetary_2008=

... in ./config.sh after running sh ./Configure?

[dilyanpalauzov]

d_lc_monetary_2008='define'

[jkeenan]

On a system (Debian Linux 11) which I believe is very similar to yours, I switched locales with:

$ export LC_ALL=POSIX; locale
LANG=en_US.UTF-8
LANGUAGE=
LC_CTYPE="POSIX"
LC_NUMERIC="POSIX"
LC_TIME="POSIX"
LC_COLLATE="POSIX"
LC_MONETARY="POSIX"
LC_MESSAGES="POSIX"
LC_PAPER="POSIX"
LC_NAME="POSIX"
LC_ADDRESS="POSIX"
LC_TELEPHONE="POSIX"
LC_MEASUREMENT="POSIX"
LC_IDENTIFICATION="POSIX"
LC_ALL=POSIX

I then configured perl (blead) normally: sh ./Configure -des -Dusedevel and observed:

$ grep -n 'monetary_2008' config.sh
350:d_lc_monetary_2008='define'

I then called make (gcc (Debian 10.2.1-6) 10.2.1 20210110). It completed successfully, i.e., it did not fail in compilation of opmini.c, as your case did.

That exhausts my knowledge of these issues. Time to call in the experts: @khwilliamson, @tonycoz, can you take a look? Thanks.

[khwilliamson]

How about the full output of config.sh

and patch Configure with this patch

Configure_patch.txt

and try again with that

[dilyanpalauzov]

The problem is with nm. When I execute ./Configure -Dusenm -d, then case "$d_locconv:$d_lc_monetary_2008" in in Configure is substituted with case "undef:" in. Then the patch does help.

If I call instead just ./Configure -d, then case "$d_locconv:$d_lc_monetary_2008" in Configure is replaced with case "define:" in and config.h contains #define HAS_LC_MONETARY_2008 /**/.

My statement above that config.h contains d_lc_monetary_2008='define' is not correct. It has this value, when I run ./Configure -d, but not when config.h contains # HAS_LC_MONETARY_2008 /**/

[khwilliamson]

On 1/7/24 08:35, Дилян Палаузов wrote: The problem is with |nm|. When I execute |./Configure -Dusenm -d|, then |case "$d_locconv:$d_lc_monetary_2008" in| in |Configure| is substituted with |case "undef:" in|. Then the patch does help. If I call instead just |./Configure -d|, then |case "$d_locconv:$d_lc_monetary_2008"| in |Configure| is replaced with |case "define:" in| and config.h contains |#define HAS_LC_MONETARY_2008 /**/|. My statement above that config.h contains |d_lc_monetary_2008='define'| is not correct. It has this value, when I run |./Configure -d|, but not when config.h contains |# HAS_LC_MONETARY_2008 /**/| — Reply to this email directly, view it on GitHub <#21803 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2DH6QH523WAFBDL5LPR3YNK6FDAVCNFSM6AAAAABBPYCJPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBQGA4TCOBQHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

Please attach config.h and config.sh with and without nm

[dilyanpalauzov]

I unpack perl-5.38.2.tar.gz in two directories: perl-5.38.2-with-nm and perl-5.38.2-without-nm

In perl-5.38.2-with-nm I do ./Configure -Dusenm -d
config.sh-with-nm.txt
config.h-with-nm.txt

In perl-5.38.2-without-nm I execute ./Configure -d
config.sh-without-nm.txt
config.h-without-nm.txt

[khwilliamson]

The files you posted with nm. Were those with or without the patch? If without, could you post the results when using the patch?

[dilyanpalauzov]

The config.sh/config.h files were without the patch. These are the files with the patch

config.sh-with-nm-patched.txt
config.h-with-nm-patched.txt

As I mentioned above the patch does help. The major problem is that nm misbehaves.