feature 'apostrophe_as_package_separator' #22675
Conversation
tonycoz
changed the title
There was a problem hiding this comment.
I have not examined the actual code of this pull-request reversion. I have attempted to examine the impact of this reversion on the set of CPAN distributions I typically look at for BBC breakage.
I pulled down this p.r. to disk (Ubuntu Linux 22.04 LTS), rebased it on blead, built a typical unthreaded perl, installed cpanm against that, then used cpanm to try to install various distributions from CPAN, including:
-
Distributions whose PASS/FAIL status regressed between our July and August development releases (and their prerequisites)
-
My "augmented CPAN-River-500" (500 distros)
These totalled approximately 661 distributions. I found no adverse effects from this p.r.
-
Distributions that originally FAILed due to apostrophe-in-names-removal and were left untouched since that went into effect and were not subsequently modified (e.g., DBIx::Class) once again PASS.
-
Distributions that originally FAILed due to apostrophe-in-names-removal but were subsequently updated by their authors/maintainers (e.g., Try::Tiny; Email-Send) still PASS.
Subject to the limitations of the QA procedure described above, this pull request LGTM.
tonycoz
force-pushed
the
22644-feature-apos-in-symbol
branch
from
26aff23
to
5cbcc69
Compare
pod/perlmod.pod
Outdated
| Using C<'> as a package separator is deprecated and will be removed in | ||
| Perl 5.40. |
There was a problem hiding this comment.
This needs updating to reflect the new situation.
There was a problem hiding this comment.
I've changed it, but wasn't sure how much to mention here.
This reverts commit 83d4e74. This also bumps the version number.
This reverts commit 87e1ec1 with some adjustments due to upstream changes.
This reverts commit ce1383e.
I'm a little hesitant over the removal of the warning identifier, since it means code that suppressed the warning in 5.38 and 5.40 will now see an error, but porting/deprecation complained when I removed the documentation from pod/perldeprecation.pod but left the warning in. An alternative would be to add a "Cancelled Removals" to perldeprecation.
tonycoz
force-pushed
the
22644-feature-apos-in-symbol
branch
from
5cbcc69
to
343ee03
Compare
Revert removal of apostrophe in package names, and the deprecation of such.
Put the use of apostrophe in package names in source behind a default enabled feature.
This includes possible changes to the CPAN upstream modules to account for the brief set of development versions where apostrophe in names was not supported, but I could see an author ignoring it. These version numbers may need to change depending on if/when this is merged.
Fixes #22644