Skip to content

hints/openbsd.sh: retain commented-out lines? #23291

Open
@jkeenan

Description

@jkeenan

In hints/openbsd.sh, we entered the following comments and statement as per $ git blame

$ git blame -L 153,157 -- hints/openbsd.sh
83f3439aaa8 (Karl Williamson 2019-04-03 14:27:00 -0600 153) # openbsd has a problem regarding newlocale()
83f3439aaa8 (Karl Williamson 2019-04-03 14:27:00 -0600 154) # https://marc.info/?l=openbsd-bugs&m=155364568608759&w=2
83f3439aaa8 (Karl Williamson 2019-04-03 14:27:00 -0600 155) # which is being fixed.  In the meantime, forbid POSIX 2008 locales
418ebdf9639 (Karl Williamson 2023-07-09 07:52:26 -0600 156) #d_newlocale="$undef"
83f3439aaa8 (Karl Williamson 2019-04-03 14:27:00 -0600 157) 

Originally, (i.e., in 2019) d_newlocale was assigned "$undef". When we became satisfied that the problem upstream had been addressed, we deactivated line 156 by commenting it out. Now, on (my admittedly obsolete OpenBSD-6.9 VM), when I run sh ./Configure, I get:

$ grep -n d_newlocale config.sh
428:d_newlocale='define'

Which appears to be working satisfactorily.

My question is: Do we need to retain any of the 4 commented-out lines above in hints/openbsd.sh?

Relevant URLs: openbsd-bugs mailing list thread beginning at
https://marc.info/?l=openbsd-bugs&m=155364568608759&w=2

discussion on a POSIX bug tracker cited in above thread:
https://austingroupbugs.net/view.php?id=1243

@khwilliamson @afresh1 @tonycoz

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions