Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The package is not compatible with Carbon v3 #4

Open
mohamed-salah-tawfik opened this issue Jul 14, 2024 · 3 comments
Open

The package is not compatible with Carbon v3 #4

mohamed-salah-tawfik opened this issue Jul 14, 2024 · 3 comments

Comments

@mohamed-salah-tawfik
Copy link

mohamed-salah-tawfik commented Jul 14, 2024

I'm using php 8.1 and laravel 11
tried to use toHijri on carbon instance but I got
Declaration of Pharaonic\Hijri\Hijri::getTranslatedDayName($context = null, $keySuffix = '', $defaultValue = null) must be compatible with Carbon\Carbon::getTranslatedDayName(?string $context = null, string $keySuffix = '', ?string $defaultValue = null): string

@MoamenEltouny
Copy link
Member

ok i will work on that

@MoamenEltouny
Copy link
Member

MoamenEltouny commented Jul 19, 2024

@mohamed-salah-tawfik it works very well, i think you need to install the latest version that already exists
please install it and give me your feedback.

@MoamenEltouny
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants