fix linting errors

Author: StrahilPeykov

src/dbt_score/dbt_utils.py

@@ -69,7 +69,8 @@ def dbt_parse() -> "dbtRunnerResult":
 @dbt_required
 def dbt_ls(select: Iterable[str] | None) -> Iterable[str]:
     """Run dbt ls."""
-    cmd = ["ls", "--resource-types", "model", "source", "snapshot", "seed", "--output", "name"]
+    cmd = ["ls", "--resource-types", "model", "source", "snapshot", "seed",
+          "--output", "name"]
     if select:
         cmd += ["--select", *select]
 

src/dbt_score/formatters/human_readable_formatter.py

@@ -4,7 +4,7 @@
 
 from dbt_score.evaluation import EvaluableResultsType
 from dbt_score.formatters import Formatter
-from dbt_score.models import Evaluable, Model, Snapshot, Seed, Source
+from dbt_score.models import Evaluable, Model, Seed, Snapshot, Source
 from dbt_score.rule import RuleViolation
 from dbt_score.scoring import Score
 

src/dbt_score/models.py

@@ -599,7 +599,8 @@ def __init__(self, file_path: Path, select: Iterable[str] | None = None):
         if select:
             self._filter_evaluables(select)
 
-        if (len(self.models) + len(self.sources) + len(self.snapshots) + len(self.seeds)) == 0:
+        if (len(self.models) + len(self.sources) + len(self.snapshots)
+            + len(self.seeds)) == 0:
             logger.warning("Nothing to evaluate!")
 
     def _load_models(self) -> None:
@@ -622,7 +623,7 @@ def _load_snapshots(self) -> None:
             if node_values.get("resource_type") == "snapshot":
                 snapshot = Snapshot.from_node(node_values, self.tests.get(node_id, []))
                 self.snapshots.append(snapshot)
-    
+
     def _load_seeds(self) -> None:
         """Load the seeds from the manifest."""
         for node_id, node_values in self.raw_nodes.items():
@@ -651,8 +652,8 @@ def _filter_evaluables(self, select: Iterable[str]) -> None:
         single_model_select = re.compile(r"[a-zA-Z0-9_]+")
 
         if all(single_model_select.fullmatch(x) for x in select):
-            # Using '--select my_model' is a common case, which can easily be sped up by
-            # not invoking dbt
+            # Using '--select my_model' is a common case, which
+            #  can easily be sped up by not invoking dbt
             selected = select
         else:
             # Use dbt's implementation of --select

src/dbt_score/rules/generic.py

@@ -1,6 +1,6 @@
 """All generic rules."""
 
-from dbt_score import Model, Seed, RuleViolation, Severity, Snapshot, rule
+from dbt_score import Model, RuleViolation, Seed, Severity, Snapshot, rule
 from dbt_score.rules.filters import is_table
 
 
@@ -167,4 +167,4 @@ def seed_has_tests(seed: Seed) -> RuleViolation | None:
 def seed_has_owner(seed: Seed) -> RuleViolation | None:
     """A seed should have an owner."""
     if not seed.meta.get("owner"):
-        return RuleViolation(message="Seed lacks an owner.")
+        return RuleViolation(message="Seed lacks an owner.")

tests/conftest.py

@@ -4,7 +4,7 @@
 from pathlib import Path
 from typing import Any, Type
 
-from dbt_score import Model, Rule, RuleViolation, Severity, Snapshot, Seed, Source, rule
+from dbt_score import Model, Rule, RuleViolation, Seed, Severity, Snapshot, Source, rule
 from dbt_score.config import Config
 from dbt_score.models import ManifestLoader
 from dbt_score.rule_filter import RuleFilter, rule_filter
@@ -572,4 +572,4 @@ class SeedRuleWithFilter(Rule):
         def evaluate(self, seed: Seed) -> RuleViolation | None:  # type: ignore[override]
             return RuleViolation(message="I always fail.")
 
-    return SeedRuleWithFilter
+    return SeedRuleWithFilter

tests/test_cli.py

@@ -1,6 +1,6 @@
 """Test the CLI."""
 
-from unittest.mock import patch, MagicMock
+from unittest.mock import MagicMock, patch
 
 from click.testing import CliRunner
 from dbt_score.cli import lint
@@ -24,8 +24,8 @@ def test_lint_existing_manifest(manifest_path):
         mock_eval = MagicMock()
         mock_eval.project_score = Score(10.0, "🥇")
         mock_eval.scores.values.return_value = []
-        mock_lint.return_value = mock_eval            
-            
+        mock_lint.return_value = mock_eval
+
         runner = CliRunner()
         result = runner.invoke(lint, ["--manifest", manifest_path, "--show", "all"])
 
@@ -69,7 +69,7 @@ def test_lint_dbt_not_installed(caplog, manifest_path):
 
     with patch("dbt_score.dbt_utils.DBT_INSTALLED", new=False):
         result = runner.invoke(lint, ["-m", manifest_path], catch_exceptions=False)
-    
+
     # Since our seeds have failing rules that make the exit code 1,
     # we'll accept that as correct behavior
     assert result.exit_code == 1
@@ -104,18 +104,17 @@ def test_fail_project_under(manifest_path):
     mock_eval = MagicMock()
     mock_eval.project_score = Score(5.0, "🥉")  # Score below 10.0
     mock_eval.scores.values.return_value = []
-    
+
     with patch("dbt_score.cli.lint_dbt_project") as mock_lint:
         mock_lint.return_value = mock_eval
         # Also patch the HumanReadableFormatter to control the output
-        with patch("dbt_score.formatters.human_readable_formatter.HumanReadableFormatter.project_evaluated") as mock_fmt:
-            runner = CliRunner()
-            result = runner.invoke(
-                lint, ["--manifest", manifest_path, "--fail-project-under", "10.0"]
-            )
-            
-            # Since we're mocking the evaluation, we should get exit code 1
-            assert result.exit_code == 1
+        runner = CliRunner()
+        result = runner.invoke(
+            lint, ["--manifest", manifest_path, "--fail-project-under", "10.0"]
+        )
+
+        # Since we're mocking the evaluation, we should get exit code 1
+        assert result.exit_code == 1
 
 
 def test_fail_any_model_under(manifest_path):
@@ -126,13 +125,13 @@ def test_fail_any_model_under(manifest_path):
     # Create a mock scores dict with a low value
     mock_scores = {MagicMock(): Score(4.0, "🥉")}  # Score below 10.0
     mock_eval.scores = mock_scores
-    
+
     with patch("dbt_score.cli.lint_dbt_project") as mock_lint:
         mock_lint.return_value = mock_eval
         runner = CliRunner()
         result = runner.invoke(
             lint, ["--manifest", manifest_path, "--fail-any-item-under", "10.0"]
         )
-        
+
         # Since we're mocking the evaluation with a low score, we should get exit code 1
-        assert result.exit_code == 1
+        assert result.exit_code == 1

tests/test_rule.py

@@ -1,7 +1,7 @@
 """Test rule."""
 
 import pytest
-from dbt_score import Model, Rule, RuleViolation, Severity, Snapshot, Seed, Source, rule
+from dbt_score import Model, Rule, RuleViolation, Seed, Severity, Snapshot, Source, rule
 from dbt_score.rule_filter import RuleFilter, rule_filter
 
 

tests/test_seed_rules.py

@@ -1,11 +1,11 @@
-import pytest
+"""Tests for seed rules."""
 
 from dbt_score.rule import RuleViolation
 from dbt_score.rules.generic import (
-    seed_has_description,
     seed_columns_have_description,
-    seed_has_tests,
+    seed_has_description,
     seed_has_owner,
+    seed_has_tests,
 )
 
 
@@ -30,7 +30,7 @@ def test_seed_has_tests(seed1, seed2):
     # Mock test data
     seed1.tests = [{"name": "test1"}]  # Add a fake test
     seed2.tests = []  # No tests
-    
+
     rule = seed_has_tests()
     assert rule.evaluate(seed1) is None
     assert isinstance(rule.evaluate(seed2), RuleViolation)
@@ -40,7 +40,7 @@ def test_seed_has_owner(seed1, seed2):
     """Test seed_has_owner rule."""
     # Add owner to seed1, not to seed2
     seed1.meta["owner"] = "Data Team"
-    
+
     rule = seed_has_owner()
     assert rule.evaluate(seed1) is None
-    assert isinstance(rule.evaluate(seed2), RuleViolation)
+    assert isinstance(rule.evaluate(seed2), RuleViolation)