Skip to content

Commit f8acb46

Browse files
authored
Remove filter in rule public_model_has_example_sql (#80)
A rule should not care about public/private models, for this a RuleFilter should be used.
1 parent 74c482f commit f8acb46

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

docs/programmatic_invocations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ $ dbt-score lint --format json
3232
"severity": "medium",
3333
"message": "Model lacks an owner."
3434
},
35-
"dbt_score.rules.generic.public_model_has_example_sql": {
35+
"dbt_score.rules.generic.has_example_sql": {
3636
"result": "OK",
3737
"severity": "low",
3838
"message": null

src/dbt_score/rules/generic.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ def sql_has_reasonable_number_of_lines(
4444

4545

4646
@rule(severity=Severity.LOW)
47-
def public_model_has_example_sql(model: Model) -> RuleViolation | None:
48-
"""The documentation of a public model should have an example query."""
49-
if model.language == "sql" and model.access == "public":
47+
def has_example_sql(model: Model) -> RuleViolation | None:
48+
"""The documentation of a model should have an example query."""
49+
if model.language == "sql":
5050
if "```sql" not in model.description:
5151
return RuleViolation(
5252
"The model description does not include an example SQL query."

0 commit comments

Comments
 (0)