JUnit4TestNotRun: remove the heuristic requirement that the method under consideration contains some kind of assertion.

This is presumably an effort to reduce false positives, but it leads to a huge number of false negatives.

PiperOrigin-RevId: 775710089

Author: graememorgan

core/src/main/java/com/google/errorprone/bugpatterns/JUnit4TestNotRun.java

@@ -37,6 +37,7 @@
 
 import com.google.common.collect.ImmutableSet;
 import com.google.errorprone.BugPattern;
+import com.google.errorprone.ErrorProneFlags;
 import com.google.errorprone.VisitorState;
 import com.google.errorprone.bugpatterns.BugChecker.ClassTreeMatcher;
 import com.google.errorprone.fixes.SuggestedFix;
@@ -119,8 +120,13 @@ private static boolean isParameterAnnotation(AnnotationTree annotation, VisitorS
 
   private static final Matcher<Tree> NOT_STATIC = not(hasModifier(STATIC));
 
+  private final boolean removeAssertionRequirement;
+
   @Inject
-  JUnit4TestNotRun() {}
+  JUnit4TestNotRun(ErrorProneFlags flags) {
+    this.removeAssertionRequirement =
+        flags.getBoolean("JUnit4TestNotRun:RemoveAssertionRequirement").orElse(true);
+  }
 
   @Override
   public Description matchClass(ClassTree tree, VisitorState state) {
@@ -212,7 +218,8 @@ private Optional<Description> handleMethod(MethodTree methodTree, VisitorState s
 
     // Method non-static and contains call(s) to testing method, probably a test,
     // unless it is called elsewhere in the class, in which case it is a helper method.
-    if (NOT_STATIC.matches(methodTree, state) && containsTestMethod(methodTree)) {
+    if (NOT_STATIC.matches(methodTree, state)
+        && (removeAssertionRequirement || containsTestMethod(methodTree))) {
       return Optional.of(describeFixes(methodTree, state));
     }
     return Optional.empty();

core/src/test/java/com/google/errorprone/bugpatterns/JUnit4TestNotRunTest.java

@@ -307,7 +307,7 @@ public void shouldDoSomething() {
   }
 
   @Test
-  public void noTestKeyword_notATest() {
+  public void noAssertions_isATestAnyway() {
     compilationHelper
         .addSourceLines(
             "Test.java",
@@ -318,6 +318,7 @@ public void noTestKeyword_notATest() {
 
             @RunWith(JUnit4.class)
             public class Test {
+              // BUG: Diagnostic contains:
               public void shouldDoSomething() {
                 Collections.sort(Collections.<Integer>emptyList());
               }
@@ -728,9 +729,6 @@ public void negativeCase3() {
  */
 @RunWith(JUnit4.class)
 public class JUnit4TestNotRunNegativeCase3 {
-  // Doesn't begin with "test", and doesn't contain any assertion-like method invocations.
-  public void thisIsATest() {}
-
   // Isn't public.
   void testTest1() {}