An Error implement about `nms`

[leftthomas]

These two lines should not add 1 for compute areas:

WTAL-Uncertainty-Modeling/utils.py

Line 101 in ea630d4

areas = x2 - x1 + 1

WTAL-Uncertainty-Modeling/utils.py

Line 111 in ea630d4

inter = np.maximum(0.0, xx2 - xx1 + 1)

Reference the implement of temporal nms in mmaction2
https://mmaction2.readthedocs.io/en/latest/api.html#id26

[Pilhyeon]

The implementation of mmaction2 might be slightly different from ours.
In ours, the temporal intervals are determined in an inclusive way, so we need to add 1 to compute areas (e.g., the interval [1, 1] has its area of 1.)

[leftthomas]

yeah, I have noticed that, and I think if we want to compute the real temporal area, for example, [1, 2], the time lasted 1 second maybe more intuitive, and such as [1, 1], the time lasted 0 second.

[Pilhyeon]

Yes, I agree with you: it is more intuitive as the temporal slicing in python also works in that way.
I will consider representing the intervals in that way in future work.
Thanks for the suggestion.