NPE due to getFromEndpoint

[furlongce]

https://www.javadoc.io/doc/org.apache.camel/camel-api/latest/org/apache/camel/Exchange.html

getFromEndpoint() - Returns the endpoint which originated this message exchange if a consumer on an endpoint created the message exchange, otherwise his property will be null.

I'm using this library w/ Apache Camel 3.13.0 and Spring Boot 2.5.x. I'm receiving a ton of NPEs since getFromEndpoint can be null, whenever a consumer on an endpoint didn't create the message exchange. This can be a problem when using direct routes, and I suspect it'll also be problematic when using forceCompletion via an AggregationController.

In general, I think it'd be safer to use getFromRouteId, though this can be null as well. However I haven't seen that happen yet in my testing.

I also noticed that all of the exchanges throwing an NPE already have a SpanId / TraceId assigned via the Exchange headers. Is there a reason that we need to create a new span at all? Or can we just use the possiblyExistingSpan?

[furlongce]

Is there any update on this, or a proposed fix? I'd be happy to implement and submit a PR

[tdanylchuk]

Hello, the repository is in hibernate state, but feel free to submit PR for this, we may initiate the release process once your issue is fixed.

[furlongce]

Should I just fork it then? I didn't realize it's not being maintained. You might want to update the readme to others won't try to use it

[tdanylchuk]

It's alive ;D and you can contribute to it, it's just not under the maintainers' priority bucket right now.

[furlongce]

Oh, that's confusing. What do you mean by hibernate state? I also want to make sure that if I fix this, it'll get released. I don't want to waste my time if it won't.

…

On Fri, Jan 7, 2022, 9:24 PM Taras Danylchuk ***@***.***> wrote: It's alive ;D and you can contribute to it, it's just not under the maintainers' priority bucket right now. — Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADR6DI27ZDWQAOSL6ILXGSLUU6N6PANCNFSM5LCJWOSQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[tdanylchuk]

it will be released once received fix