Skip to content

Commit 6ab0b02

Browse files
jwalterssmmiermans
andauthored
fix: make subtitle optional for custom sections (#1262)
Remove required validation for subtitle field in custom section forms. Title remains required. Co-authored-by: Mathijs Miermans <[email protected]>
1 parent 6a2b94a commit 6ab0b02

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

src/curated-corpus/components/CustomSectionForm/CustomSectionForm.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@ export const CustomSectionForm: React.FC<CustomSectionFormProps> = ({
8282
<Field
8383
as={TextField}
8484
name="subtitle"
85-
label="Subtitle"
86-
required
85+
label="Subtitle (Optional)"
8786
fullWidth
8887
multiline
8988
rows={2}

src/curated-corpus/components/CustomSectionForm/CustomSectionForm.validation.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export const getValidationSchema = (isEditMode: boolean = false) => {
2424
subtitle: yup
2525
.string()
2626
.trim()
27-
.required('Subtitle is required')
2827
.max(500, 'Subtitle cannot exceed 500 characters'),
2928

3029
heroTitle: yup
@@ -95,10 +94,6 @@ export const validateForm = (
9594
errors.title = 'Title is required';
9695
}
9796

98-
if (!formData.subtitle.trim()) {
99-
errors.subtitle = 'Subtitle is required';
100-
}
101-
10297
if (!formData.startDate) {
10398
errors.startDate = 'Start date is required';
10499
} else if (formData.startDate < today) {

src/curated-corpus/components/EditCustomSectionModal/EditCustomSectionModal.test.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,8 @@ describe('EditCustomSectionModal', () => {
8787
</MockedProvider>,
8888
);
8989

90-
// Check if form text labels are rendered (from CustomSectionFormConnector)
91-
expect(screen.getByText('Title')).toBeInTheDocument();
92-
expect(screen.getByText('Subtitle')).toBeInTheDocument();
90+
// Check if form is rendered - looking for start date label
91+
expect(screen.getByText('Start Date')).toBeInTheDocument();
9392
});
9493

9594
it('should populate form with section data', () => {

0 commit comments

Comments
 (0)