Skip to content

Commit 58ea61e

Browse files
authored
feat(clientapi): add operation name and errors to otel instrumentation (#1021)
1 parent b1e828c commit 58ea61e

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

docker-compose.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ services:
9696
retries: 30
9797
ports:
9898
- '9090:9090'
99-
99+
100100
otlpcollector:
101101
image: grafana/otel-lgtm
102102
ports:
@@ -106,19 +106,22 @@ services:
106106
- 4318:4318 # OTLP http receiver
107107
- 3000:3000 # Grafana
108108

109-
# Uncomment this if you want to run the collector locally and send to GCP instead of the one used for local development
110-
# Make sure to have a service json in GOOGLE_APPLICATION_CREDENTIALS_JSON in the .env file
109+
110+
# # Uncomment this if you want to run the collector locally and send to GCP instead of the one used for local development
111+
# # Make sure to have a service json in GOOGLE_APPLICATION_CREDENTIALS_JSON in the .env file
111112
# otlpcollector:
112113
# build:
113114
# context: ./servers/otel-collector
114115
# dockerfile: Dockerfile
115116
# env_file:
116117
# - .env
118+
# volumes:
119+
# - ./servers/otel-collector/otel-collector-config.yaml:/etc/otelcol-contrib/config.yaml
117120
# environment:
118121
# - DEPLOYMENT_ENVIRONMENT_NAME=local
119122
# ports:
120123
# # there are lots more ports available, but these are the only one's
121124
# # currently being used
122125
# - 4317:4317 # OTLP gRPC receiver
123126
# - 4318:4318 # OTLP http receiver
124-
# - 3000:3000 # Grafana
127+
# - 3000:3000 # Grafana

servers/client-api/config/router.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,17 @@ telemetry:
9494
request_header: 'apollographql-client-version'
9595
http.server.request.duration:
9696
attributes:
97+
http.response.status_code: true
9798
'http.request.header.apollographql-client-name':
9899
request_header: 'apollographql-client-name'
99100
'http.request.header.apollographql-client-version':
100101
request_header: 'apollographql-client-version'
102+
'graphql.operation.name': # Will set this attribute with the operation name
103+
operation_name: string
104+
'graphql.errors': # Will set this attribute to true if it contains graphql error (includes unauthorized)
105+
on_graphql_error: true
106+
'graphql.critical.error':
107+
error: reason
101108
subgraph:
102109
http.client.request.body.size:
103110
attributes:

0 commit comments

Comments
 (0)