Skip to content

Commit 7e1f337

Browse files
committed
Make Exception and KafkaAdapterManager public vis
Signed-off-by: Adam Glustein <[email protected]>
1 parent 9168324 commit 7e1f337

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

.github/workflows/conda.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ jobs:
3232
strategy:
3333
matrix:
3434
os:
35-
- ubuntu-24.04
36-
- macos-14
37-
- macos-12
35+
# - ubuntu-24.04
36+
# - macos-14
37+
# - macos-12
3838
- windows-2019
3939
runs-on: ${{ matrix.os }}
4040
steps:

cpp/csp/adapters/kafka/KafkaAdapterManager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ struct KafkaStatusMessageTypeTraits
4949
using KafkaStatusMessageType = csp::Enum<KafkaStatusMessageTypeTraits>;
5050

5151
//Top level AdapterManager object for all kafka adapters in the engine
52-
class CSPKAFKAADAPTERIMPL_EXPORT KafkaAdapterManager final : public csp::AdapterManager
52+
class CSP_PUBLIC KafkaAdapterManager final : public csp::AdapterManager
5353
{
5454
public:
5555
KafkaAdapterManager( csp::Engine * engine, const Dictionary & properties );

cpp/csp/core/Exception.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
namespace csp
1111
{
1212

13-
class CSPCORE_EXPORT Exception : public std::exception
13+
class CSP_PUBLIC Exception : public std::exception
1414
{
1515
public:
1616
Exception( const char * exType, const std::string & description, const char * file, const char * func, int line ) :

cpp/csp/engine/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ generate_export_header(csp_types
8787
EXPORT_MACRO_NAME CSPTYPES_EXPORT
8888
)
8989
set_target_properties(csp_types PROPERTIES PUBLIC_HEADER "${CSP_TYPES_PUBLIC_HEADERS}")
90+
target_link_libraries(csp_types csp_core)
9091

9192
add_library(csp_engine STATIC ${ENGINE_SOURCE_FILES})
9293
generate_export_header(csp_engine

cpp/csp/engine/TimeSeries.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class CSPENGINE_EXPORT TimeSeries
6060
{
6161
public:
6262
// Should match the DuplicatePolicy enum in python!!!
63-
struct DuplicatePolicyTraits {
63+
struct CSPENGINE_EXPORT DuplicatePolicyTraits {
6464
enum _enum : uint8_t {
6565
UNKNOWN = 0,
6666
LAST_VALUE = 1,

0 commit comments

Comments
 (0)