-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Open
Labels
effort: lowRough estimate of time needed to fix/implement/solveRough estimate of time needed to fix/implement/solvegood first issueSkills/areas of expertise needed to tackle the issueSkills/areas of expertise needed to tackle the issuekind: todoType of issueType of issue
Description
This issue is to split PR #4249 into smaller pieces.
With destructors I use the following policy:
if your class defines virtual methods which it defines (literally defining, not overriding), I explicitly default it. The compiler throws warnings telling if of your class has virtual methods but the destructor is not virtual.
If a class has empty / default destructors I just remove those lines of code. If the destructor is not implicitly generated you'll get a compiler error, so there's no chance you'll mess up.
For constructors: remove all default constructors unless there's a user defined (non-default) constructor.
Metadata
Metadata
Assignees
Labels
effort: lowRough estimate of time needed to fix/implement/solveRough estimate of time needed to fix/implement/solvegood first issueSkills/areas of expertise needed to tackle the issueSkills/areas of expertise needed to tackle the issuekind: todoType of issueType of issue