-
-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements for a V3(beta) #1086
Comments
Hi, so far the APIv2 had a great success and the only big problem for the user is understanding the difference between pokemon, pokemon-species, pokemon-forms. I say we cannot modify the current properties nor delete them but only add them for the current API due to the huge consumption, as we have done so far. That said other small problems were raised in the past. I'll write down a small list of thoughts
But maybe this adds difficulties in understanding. To be honest the point This are just some thoughts. |
I'll add my own personal thoughts, with the
Additional understanding question: How/Where are the static files served? Is it just json-formatted files outputted somewhere? |
One thing I would, as a user, specifically request is NOT to drop non-GQL support. GraphQL is powerful, but it's a huge pain to interface with if you aren't using a pretty heavyweight library to do most of it for you. So far, the biggest complaints I have that I would like to see addressed:
|
I get why FlavorTexts/Proses are localized, but do we actually want the same for Effect Texts? |
I agree with the ID being the name of the pokemon! And getting rid of the conquest data. |
@GreatNovaDragon the long effect / short effect texts make sense for some categories such as moves / abilities. I didn't like the data provided by PokéAPI so I've rewritten all of them along with a custom parser. |
I am currently writing some code for some reduced personalized usecases in a repo mirrored to GreatNovaDragon/pokeapi-nova i probably could later expand that into full API that displays most of the PokeAPI Data. Will still take a while |
Several things like Moves, Abilities, Pokemon have an Generation field, which should be replaced with VersionGroup. Like, platinum version-group already introduced an alternate Pokemon Form in Girantina Origin Forme, so i dont know why that already wasnt in veekun/pokedex, maybe they thought it was a oneoff? |
As far as I'm aware Veekun stopped just before SWSH. Did they already include USUM data? USUM introduced a bunch of Gen 7 moves that were released after SM, so just listing Gen 7 for is not completely correct as SM does not include those moves. |
In GreatNovaDragon/PokeAPI-Nova (far from finished), I have set the "IntroducedIn" field as a Version group. Given that for #1020 I am already doing my own research, finding out in which version group something released in is the smallest issue. |
Just chimining in to say I'm very busy with some pretty awful things happening in my life at the moment (my youngest son just passed away). So I don't really have time to comment or contribute other than saying: I give my grace (whatever that is worth) for you all to build this. I trust ya 😄 |
I'm very sorry to hear that @phalt no parent should ever go through that. |
First of, i am taking reference to this message by @Naramsim here
Originally posted by @Naramsim in #1037 (comment)
As much as i personally would love to start anew, there are some informations missing before one could actually do such,
What are the requirements to an v3 (Technical or Modelwise)? What should be carried over from v2? What explicitely not? Or does nothing matter and someone should just start?
The text was updated successfully, but these errors were encountered: