Source Collector: Agency Not Found URL status

[josh-chamberlain]

When a user clicks "Agency Not Found", and I go into the batch to label it, I see the URLs there—for example, in batch 9, a user reported hitting "agency not found" on all the remaining URLs.

1. It's nice that I am able to "correct" this—sometimes they just can't find the right agency. So it's neat that I can see the URLs, even though they can't.
2. What's the status of these URLs after "Agency not Found" is clicked? Do they go to Final Review?

[maxachis]

In the database, they are marked as annotated but with an is_new flag activated. They should nonetheless still appear on the final review screen, however. Now that I've resolved the issue in #304 , have a look and see if they do appear as you work through the URLs!

[josh-chamberlain]

@maxachis getting there! What does the "is_new" flag do? Can we make it highlight the Agencies section with some kind of "Labeled as not found" message?

Still a bit of weirdness:

One came in with a blank agency; I selected the proper one (Pittsburgh Bureau of Police) and clicked "Finalize Labels and Submit".

On the next URL, I see the following (note the "undefined" agency prepopulated with the ID of the Pittsburgh agency from the previous step) (fig 1).

When I go to add the correct agency, I cannot click the trashcan icon to remove the undefined agency from the list, even after I select the right agency (Maryland Aggregated). (fig 2) This is happening on URL ID 1118

Fig 1

Fig 2

[maxachis]

@josh-chamberlain Alright, I gave it some love and attention: Try it now and see if they still pop up!

[josh-chamberlain]

@maxachis After approving that one, I still get the same issue on the next:

There's an undefined agency, the last one I added. Are you seeing the same issue?

[maxachis]

@josh-chamberlain I think there might have been another bug which I've addressed, although it's hard to validate since we've got everything running against production and we can't easily run tests. It might be the sort of thing we need to run through together during a coworking sesh.🤔 For the moment, a workaround can be made by refreshing the page.

[josh-chamberlain]

@maxachis have you tried approving labels yourself? I'm now seeing that post and get next source and get next source are failing.

[josh-chamberlain]

here's the latest example, URL ID 1157—the previous label I finalized and submitted was for the Clarkston Police Department of Asotin County Washington, ID 21710. After I submitted that one, this next one looks like so:

This was one I remember labeling as being for the Allegheny County Jail, so that's getting wiped out and I have to re-label the agency when doing final approval.

[maxachis]

@josh-chamberlain Just applied a fix! There are wonky bits in retool that aren't immediately apparent. Keep me appraised if it shows up again!

[josh-chamberlain]

@maxachis unfortunately it has: