Skip to content

Commit 077da06

Browse files
author
Mikołaj Piechocki
committedDec 11, 2020
Added comment to hint where some UI work could possibly be done
1 parent 6556a40 commit 077da06

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed
 

‎ExampleApp/ExampleApp/Screens/CentralServices/CentralServicesViewController.swift

+2
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ class CentralSericesViewController: UITableViewController {
7777
didAppearSubject
7878
.take(1)
7979
.flatMap { [bluetoothProvider, peripheral] in bluetoothProvider.discoveredServices(for: peripheral) }
80+
// discovering characterisics can take some time so it might be useful to block UI or show progress bar here,
81+
// probably with .do(onSubscribe: { startProgressIndicator() }, onCompleted: { stopProgressIndicator() })
8082
.subscribe(
8183
onNext: { [weak self] in self?.services = $0 },
8284
onError: { [weak self] in

0 commit comments

Comments
 (0)