fixes for some FIXME and TODO items

Author: nuke-web3

book.toml

@@ -14,9 +14,9 @@ create-missing = false # opt out of helper to create missing stub files, we want
 edition = "2021"
 
 [output.html]
-site-url = "/book/" # needed for gh-pages, MUST match repo name on github!
-git-repository-url = "https://github.com/Polkadot-Blockchain-Academy/book"
-edit-url-template = "https://github.com/Polkadot-Blockchain-Academy/book/edit/main/{path}"
+site-url = "/pba-book/" # needed for gh-pages, MUST match repo name on github!
+git-repository-url = "https://github.com/Polkadot-Blockchain-Academy/pba-book"
+edit-url-template = "https://github.com/Polkadot-Blockchain-Academy/pba-book/edit/main/{path}"
 
 [output.html.search]
 limit-results = 20

content/README.md

@@ -8,7 +8,7 @@ We suggest the [online](#hosted-online) version for general use, but cloning, in
 
 ### Hosted Online
 
-The latest version is hosted at: <a target="_blank" href="https://polkadot-blockchain-academy.github.io/testing-only/">https://polkadot-blockchain-academy.github.io/testing-only/</a> FIXME
+The latest version is hosted at: <a target="_blank" href="https://polkadot-blockchain-academy.github.io/pba-book/">https://polkadot-blockchain-academy.github.io/pba-book/</a>
 
 ### Build Offline
 

content/blockchain-contracts/bytecode/slides.md

@@ -663,7 +663,7 @@ Notes:
 
 - `extern "C"`:
 
-  - > https://doc.rust-lang.org/std/keyword.extern.html>
+  - <https://doc.rust-lang.org/std/keyword.extern.html>
   - <https://doc.rust-lang.org/book/ch19-01-unsafe-rust.html#using-extern-functions-to-call-external-code>
 
 - Chapter 11 of this book is a great read: <https://nostarch.com/rust-rustaceans>

content/blockchain-contracts/infrastructure/slides.md

@@ -123,7 +123,7 @@ Tomorrow and Thursday will dig in on how the blockchain and its P2P network work
 
 ## Blockchain Data structure
 
-todo figure FIXME
+<img width="60%" src="../structure/img/forks.svg">
 
 Notes:
 
@@ -135,7 +135,7 @@ This one is forked which is when things get really interesting, and when you nee
 
 ## Blockchain Consensus
 
-todo FIXME
+<img width="60%" src="../finality/img/byzantine-generals.png">
 
 Notes:
 

content/blockchain-contracts/ink-workshop/slides.md

@@ -218,7 +218,8 @@ It contains the game metadata. You will need this in order to interact with the
 
 Notes:
 
-And it has 2 todo files. The first is some instructions on General setup and the second one is in order to build your player.
+And it has 2 `todo` files.
+The first is some instructions on General setup and the second one is in order to build your player.
 
 ---
 

content/blockchain-contracts/light-clients-bridges/slides.md

@@ -445,8 +445,20 @@ Your app is only as quality as the lower of the blockspaces.
 
 ---v
 
-## Example
+## Example: Depository Mint Model
 
-Depository - Mint model - Full backing
+- Send tokens to a contract on source chain
+- Message is relayed to destination chain
+  - Offchain relay and transaction
+  - XCM
+  - "Somehow"
+- New "wrapped" tokens are minted on the destination chain
 
-TODO - complete slide
+<!-- TODO really needs a figure -->
+
+Notes:
+
+The same process works in reverse to get the original tokens back.
+This can get get complex when there are multiple bridges.
+Are their wrapped tokens interchangeable?
+What if one of the bridges gets hacked?

content/blockchain-contracts/services-as-state-machines/img/garage-door-keypad.jpg

@@ -381,7 +381,7 @@ If that is not possible, draw a partial LTS.
 
 ## Garage Door Lock
 
-TODO figure of garage door opener
+<img rounded width="60%" src="./img/garage-door-keypad.jpg" />
 
 Notes:
 
@@ -392,9 +392,7 @@ If the user enters the correct 4 digits, the door opens (or closes if it was alr
 The thing is, you could enter some random digits before you enter the correct code, and it would still open after the correct code.
 As you sketch your states, be sure to handle that correctly.
 
-This example is drawn from <https://eng.libretexts.org/Under_Construction/Book%3A_Discrete_Structures/09%3A_Finite-State_Automata/9.02%3A_State_Transition_Diagrams> which has many other excellent examples
-
-TODO add this example to blockchain from scratch.
+This example is drawn from https://eng.libretexts.org/Under_Construction/Book%3A_Discrete_Structures/09%3A_Finite-State_Automata/9.02%3A_State_Transition_Diagrams which has many other excellent examples
 
 ---
 

content/blockchain-contracts/services-as-state-machines/slides.md

@@ -312,7 +312,7 @@ makers l
 
 The checker uses the `.github/workflows/mlc_config.json` configuration, primarily used to _globally_ ignore specific common URLs that throw errors, in error 😛.
 _Notice that ignored links must be check from time to time manually!_
-_Thus don't use this unless explicitly needed, rather use a know good URL if at all possible, perhaps from the <https://web.archive.org/>_
+_Thus don't use this unless explicitly needed, rather use a know good URL if at all possible, perhaps from the <https://archive.org/web/>_
 The same tool is also run by our CI on all files for all pushes to all branches.
 See the `.github/workflows/link-check.yml` file in this repo for details.
 

content/contribute/index.md

@@ -143,7 +143,7 @@ Note:
 
 Notes:
 
-- [Great blog](https://web.archive.org/web/20230209000724/www.pl-enthusiast.net/2017/10/23/what-is-soundness-in-static-analysis/) that explains the trade-offs between soundness and tractability
+- [Great blog](https://web.archive.org/web/20230209000724/www.pl-enthusiast.net/2017/10/23/what-is-soundness-in-static-analysis/) that explains the trade-offs between soundness and tractability <!-- markdown-link-check-disable-line -->
 
 ---