Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previews: OpenGraph & Twitter cards #109

Open
luckydonald opened this issue Oct 18, 2016 · 7 comments
Open

Previews: OpenGraph & Twitter cards #109

luckydonald opened this issue Oct 18, 2016 · 7 comments
Labels
backend feature

Comments

@luckydonald
Copy link

luckydonald commented Oct 18, 2016 •
edited
Loading

Support rich previews.

Open Graph Docs: http://opengraphprotocol.org/#type_music
Twitter cards Docs: https://dev.twitter.com/cards/types/player

For example Telegram uses open graph:

2016-10-18 18_45_50-clipboard
https://pony.fm/tracks/23497-we-will-stand-for-everfree-vocal-cover
https://soundcloud.com/djpon3official/ponies
@luckydonald luckydonald changed the title Previews: OpenGraph & Twitter cards for preview Previews: OpenGraph & Twitter cards Oct 18, 2016
@ghost ghost added the feature label Oct 18, 2016
@luckydonald
Copy link
Author

luckydonald commented Oct 18, 2016 •
edited
Loading

What places (files) would that best go?

@ghost
Copy link

ghost commented Oct 18, 2016

That'd be all done inside of resources/views. All views share the same head tag in shared/_layout.blade.php

@luckydonald
Copy link
Author

luckydonald commented Oct 18, 2016 •
edited
Loading

I'll see if I find time to work on a PR :D

@ghost
Copy link

ghost commented Oct 18, 2016

Awesome. I'll shoot you a code review when you post it

@luckydonald
Copy link
Author

luckydonald commented Oct 18, 2016 •
edited
Loading

The song view (https://pony.fm/tracks/{number}) ends up to be resources/views/tracks/embed.blade.php, right?

@ghost
Copy link

ghost commented Oct 18, 2016

That's for the embedded player. The track page is resources/views/tracks/show.blade.php

@ghost ghost self-assigned this Oct 23, 2016
@ghost ghost added the in progress label Oct 30, 2016
ghost pushed a commit that referenced this issue Oct 30, 2016
#109: Open Graph and Twitter cards for tracks
abc521b
ghost pushed a commit that referenced this issue Oct 30, 2016
#109: Removed leftover placeholder code
5094422
ghost pushed a commit that referenced this issue Oct 30, 2016
#109: Added secure_url because Facebook was complaining
d67ff0b
@ghost
Copy link

ghost commented Nov 25, 2016

Open Graph and Twitter cards are in but there's some bugs, need to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EventideGlow @luckydonald