Allow 404 exceptions to propagate

haacked · haacked · commit 8e6263e7e440 · 2025-05-03T15:00:36.000-07:00
Don't try to read the response body.
diff --git a/src/PostHog/Library/HttpClientExtensions.cs b/src/PostHog/Library/HttpClientExtensions.cs
@@ -45,11 +45,17 @@ public static async Task EnsureSuccessfulApiCall(
         this HttpResponseMessage response,
         CancellationToken cancellationToken)
     {
-        // TODO: Is there any error status codes that we should allow the exception to propagate here?
         if (response.IsSuccessStatusCode)
         {
             return;
         }
+
+        if (response.StatusCode == HttpStatusCode.NotFound)
+        {
+            // Allow 404 exception to propagate up.
+            response.EnsureSuccessStatusCode();
+        }
+
         var (error, exception) = await ReadApiErrorResultAsync();
 
         throw response.StatusCode switch

Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,17 @@ public static async Task EnsureSuccessfulApiCall(`
`45`	`45`	`this HttpResponseMessage response,`
`46`	`46`	`CancellationToken cancellationToken)`
`47`	`47`	`{`
`48`		`- // TODO: Is there any error status codes that we should allow the exception to propagate here?`
`49`	`48`	`if (response.IsSuccessStatusCode)`
`50`	`49`	`{`
`51`	`50`	`return;`
`52`	`51`	`}`
	`52`	`+`
	`53`	`+ if (response.StatusCode == HttpStatusCode.NotFound)`
	`54`	`+ {`
	`55`	`+ // Allow 404 exception to propagate up.`
	`56`	`+ response.EnsureSuccessStatusCode();`
	`57`	`+ }`
	`58`	`+`
`53`	`59`	`var (error, exception) = await ReadApiErrorResultAsync();`
`54`	`60`
`55`	`61`	`throw response.StatusCode switch`