-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
ciRelated to CI setupRelated to CI setup
Description
Problem
We have memory tests, but those are flaky and cause CI failure. They have to be manually updated from time to time
postgrest/test/memory/memory-tests.sh
Lines 105 to 119 in d005ed3
| jsonKeyTest "1M" "POST" "/rpc/leak?columns=blob" "22M" | |
| jsonKeyTest "1M" "POST" "/leak?columns=blob" "22M" | |
| jsonKeyTest "1M" "PATCH" "/leak?id=eq.1&columns=blob" "22M" | |
| jsonKeyTest "10M" "POST" "/rpc/leak?columns=blob" "32M" | |
| jsonKeyTest "10M" "POST" "/leak?columns=blob" "32M" | |
| jsonKeyTest "10M" "PATCH" "/leak?id=eq.1&columns=blob" "32M" | |
| jsonKeyTest "50M" "POST" "/rpc/leak?columns=blob" "73M" | |
| jsonKeyTest "50M" "POST" "/leak?columns=blob" "73M" | |
| jsonKeyTest "50M" "PATCH" "/leak?id=eq.1&columns=blob" "73M" | |
| postJsonArrayTest "1000" "/perf_articles?columns=id,body" "21M" | |
| postJsonArrayTest "10000" "/perf_articles?columns=id,body" "22M" | |
| postJsonArrayTest "100000" "/perf_articles?columns=id,body" "25M" |
Solution
To not cause CI failures, it would be better to show a summary like we do for the loadtests (example).
We still could have upper bounds for memory there to note them at review time.
Notes
-
Even more interesting would be to render the full profile report. For the memory tests currently we only get the "total alloc" value by parsing on bash.
-
Combining the profile report with the loadtests could provide more valuable data.
Metadata
Metadata
Assignees
Labels
ciRelated to CI setupRelated to CI setup