Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make env vars optional for default allow list path #757

Open
wants to merge 3 commits into
base: latestw_all
Choose a base branch
from
Open

make env vars optional for default allow list path #757

wants to merge 3 commits into from

Conversation

tgauth
Copy link
Collaborator

@tgauth tgauth commented Oct 14, 2024 •
edited
Loading

PR Summary

  • remove fatal() calls if either env:ProgramFiles and env:ProgramFiles(X86) is not present (and allow list is not configured with -P), and instead fallback on initializing an empty allow list
  • lowercase provider paths before match_pattern_list() to prevent false negatives

PR Context

@tgauth tgauth requested a review from anmenaga October 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmenaga anmenaga Awaiting requested review from anmenaga

@vthiebaut10 vthiebaut10 Awaiting requested review from vthiebaut10

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v9.8.1.0 x86 MSI install / ssh-agent startup failure
1 participant
@tgauth