Skip to content

Conversation

@mikasenghaas
Copy link
Member

Description

Handles the special case of the logprobs field in the chat completion object being a dictionary instead of a Pydantic model which we have found to greatly improve serialization speed and hence use in PRIME-RL.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes

@mikasenghaas mikasenghaas changed the base branch from trajectories to main November 20, 2025 07:25
@mikasenghaas mikasenghaas force-pushed the mika/allow-logprob-dict branch from e71c914 to e9b5e30 Compare November 28, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants